From: Gerhard Jaeger <g.jaeger@sysgo.com>
To: linuxppc-embedded@ozlabs.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] FS_ENET: use PAL for mii management
Date: Wed, 21 Jun 2006 09:20:36 +0200 [thread overview]
Message-ID: <200606210920.37295.g.jaeger@sysgo.com> (raw)
In-Reply-To: <20060620145840.24807.30296.stgit@vitb.ru.mvista.com>
Hi,
On Tuesday 20 June 2006 16:58, Vitaly Bordug wrote:
>
> This patch should update the fs_enet infrastructure to utilize
> Phy Abstraction Layer subsystem. Inside there are generic driver rehaul,
> board-specific portion to respect driver changes (for 8272ads and 866ads).
>
> Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
> ---
>
> arch/ppc/platforms/mpc8272ads_setup.c | 154 ++++++----
> arch/ppc/platforms/mpc866ads_setup.c | 192 ++++++------
> arch/ppc/platforms/mpc885ads_setup.c | 179 ++++--------
> arch/ppc/syslib/mpc8xx_devices.c | 8 +
> arch/ppc/syslib/mpc8xx_sys.c | 6
> arch/ppc/syslib/pq2_devices.c | 5
> arch/ppc/syslib/pq2_sys.c | 3
> drivers/net/fs_enet/Makefile | 6
> drivers/net/fs_enet/fec.h | 42 +++
> drivers/net/fs_enet/fs_enet-main.c | 207 ++++++++-----
> drivers/net/fs_enet/fs_enet-mii.c | 507 ---------------------------------
> drivers/net/fs_enet/fs_enet.h | 40 ++-
> drivers/net/fs_enet/mac-fcc.c | 10 -
> drivers/net/fs_enet/mac-fec.c | 132 +--------
> drivers/net/fs_enet/mac-scc.c | 4
> drivers/net/fs_enet/mii-bitbang.c | 384 +++++++++++++++----------
> drivers/net/fs_enet/mii-fec.c | 243 ++++++++++++++++
> drivers/net/fs_enet/mii-fixed.c | 92 ------
> include/asm-ppc/mpc8260.h | 1
> include/asm-ppc/mpc8xx.h | 1
> include/linux/fs_enet_pd.h | 50 +--
> 21 files changed, 983 insertions(+), 1283 deletions(-)
[SNIPSNAP]
> diff --git a/drivers/net/fs_enet/mii-bitbang.c b/drivers/net/fs_enet/mii-bitbang.c
> index 24a5e2e..145bf4c 100644
> --- a/drivers/net/fs_enet/mii-bitbang.c
> +++ b/drivers/net/fs_enet/mii-bitbang.c
> @@ -34,6 +34,7 @@
> #include <linux/mii.h>
> #include <linux/ethtool.h>
> #include <linux/bitops.h>
> +#include <linux/platform_device.h>
>
> #include <asm/pgtable.h>
> #include <asm/irq.h>
> @@ -41,6 +42,7 @@
>
> #include "fs_enet.h"
>
> +
> #ifdef CONFIG_8xx
> static int bitbang_prep_bit(u8 **dirp, u8 **datp, u8 *mskp, int port, int bit)
> {
> @@ -106,64 +108,25 @@ static int bitbang_prep_bit(u8 **dirp, u
> }
> #endif
>
> -#ifdef CONFIG_8260
> -static int bitbang_prep_bit(u8 **dirp, u8 **datp, u8 *mskp, int port, int bit)
> +static int bitbang_prep_bit(u8 **datp, u8 *mskp,
> + struct fs_mii_bit *mii_bit)
is it possible, that in case of CONFIG_8xx you'll have two times this
bitbang_prep_bit() function?
Gerhard
--
Gerhard Jaeger <gjaeger@sysgo.com>
SYSGO AG Embedded and Real-Time Software
www.sysgo.com | www.elinos.com | www.pikeos.com | www.osek.de
WARNING: multiple messages have this Message-ID (diff)
From: Gerhard Jaeger <g.jaeger@sysgo.com>
To: linuxppc-embedded@ozlabs.org
Cc: Vitaly Bordug <vbordug@ru.mvista.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] FS_ENET: use PAL for mii management
Date: Wed, 21 Jun 2006 09:20:36 +0200 [thread overview]
Message-ID: <200606210920.37295.g.jaeger@sysgo.com> (raw)
In-Reply-To: <20060620145840.24807.30296.stgit@vitb.ru.mvista.com>
Hi,
On Tuesday 20 June 2006 16:58, Vitaly Bordug wrote:
>
> This patch should update the fs_enet infrastructure to utilize
> Phy Abstraction Layer subsystem. Inside there are generic driver rehaul,
> board-specific portion to respect driver changes (for 8272ads and 866ads).
>
> Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
> ---
>
> arch/ppc/platforms/mpc8272ads_setup.c | 154 ++++++----
> arch/ppc/platforms/mpc866ads_setup.c | 192 ++++++------
> arch/ppc/platforms/mpc885ads_setup.c | 179 ++++--------
> arch/ppc/syslib/mpc8xx_devices.c | 8 +
> arch/ppc/syslib/mpc8xx_sys.c | 6
> arch/ppc/syslib/pq2_devices.c | 5
> arch/ppc/syslib/pq2_sys.c | 3
> drivers/net/fs_enet/Makefile | 6
> drivers/net/fs_enet/fec.h | 42 +++
> drivers/net/fs_enet/fs_enet-main.c | 207 ++++++++-----
> drivers/net/fs_enet/fs_enet-mii.c | 507 ---------------------------------
> drivers/net/fs_enet/fs_enet.h | 40 ++-
> drivers/net/fs_enet/mac-fcc.c | 10 -
> drivers/net/fs_enet/mac-fec.c | 132 +--------
> drivers/net/fs_enet/mac-scc.c | 4
> drivers/net/fs_enet/mii-bitbang.c | 384 +++++++++++++++----------
> drivers/net/fs_enet/mii-fec.c | 243 ++++++++++++++++
> drivers/net/fs_enet/mii-fixed.c | 92 ------
> include/asm-ppc/mpc8260.h | 1
> include/asm-ppc/mpc8xx.h | 1
> include/linux/fs_enet_pd.h | 50 +--
> 21 files changed, 983 insertions(+), 1283 deletions(-)
[SNIPSNAP]
> diff --git a/drivers/net/fs_enet/mii-bitbang.c b/drivers/net/fs_enet/mii-bitbang.c
> index 24a5e2e..145bf4c 100644
> --- a/drivers/net/fs_enet/mii-bitbang.c
> +++ b/drivers/net/fs_enet/mii-bitbang.c
> @@ -34,6 +34,7 @@
> #include <linux/mii.h>
> #include <linux/ethtool.h>
> #include <linux/bitops.h>
> +#include <linux/platform_device.h>
>
> #include <asm/pgtable.h>
> #include <asm/irq.h>
> @@ -41,6 +42,7 @@
>
> #include "fs_enet.h"
>
> +
> #ifdef CONFIG_8xx
> static int bitbang_prep_bit(u8 **dirp, u8 **datp, u8 *mskp, int port, int bit)
> {
> @@ -106,64 +108,25 @@ static int bitbang_prep_bit(u8 **dirp, u
> }
> #endif
>
> -#ifdef CONFIG_8260
> -static int bitbang_prep_bit(u8 **dirp, u8 **datp, u8 *mskp, int port, int bit)
> +static int bitbang_prep_bit(u8 **datp, u8 *mskp,
> + struct fs_mii_bit *mii_bit)
is it possible, that in case of CONFIG_8xx you'll have two times this
bitbang_prep_bit() function?
Gerhard
--
Gerhard Jaeger <gjaeger@sysgo.com>
SYSGO AG Embedded and Real-Time Software
www.sysgo.com | www.elinos.com | www.pikeos.com | www.osek.de
next prev parent reply other threads:[~2006-06-21 7:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-20 14:58 [PATCH 1/3] PAL: Support of the fixed PHY Vitaly Bordug
2006-06-20 14:58 ` Vitaly Bordug
2006-06-20 14:58 ` [PATCH 2/3] FS_ENET: use PAL for mii management Vitaly Bordug
2006-06-20 14:58 ` Vitaly Bordug
2006-06-21 7:20 ` Gerhard Jaeger [this message]
2006-06-21 7:20 ` Gerhard Jaeger
2006-06-21 7:38 ` Vitaly Bordug
2006-06-21 7:38 ` Vitaly Bordug
2006-06-20 14:58 ` [PATCH 3/3] FS_ENET: phydev pointer may be dereferenced without NULL check Vitaly Bordug
2006-06-20 14:58 ` Vitaly Bordug
-- strict thread matches above, loose matches on Subject: below --
2006-06-21 16:09 [PATCH 1/3] PAL: Support of the fixed PHY Vitaly Bordug
2006-06-21 16:10 ` [PATCH 2/3] FS_ENET: use PAL for mii management Vitaly Bordug
2006-06-21 16:10 ` Vitaly Bordug
[not found] <20060807232913.13951.54542.stgit@localhost.localdomain>
2006-08-07 23:30 ` Vitaly Bordug
[not found] <20060807235112.14154.43199.stgit@localhost.localdomain>
2006-08-07 23:54 ` Vitaly Bordug
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200606210920.37295.g.jaeger@sysgo.com \
--to=g.jaeger@sysgo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.