Re: [PATCH] swsusp: add architecture special saveable pages support

Re: [PATCH] swsusp: add architecture special saveable pages support

[Dave Jones]

On Fri, Jun 23, 2006 at 03:01:32PM +0000, Linux Kernel wrote:
 > commit ce4ab0012b32c1a4a1d6e934aeb73bf3151c48d9
 > tree 83b5ba44e93eeb8b72fe14028ac25943f77844fe
 > parent 82dcaafc92fdfbe2c1d6c50b9f5e17d533caf950
 > author Shaohua Li <shaohua.li@intel.com> Fri, 23 Jun 2006 16:04:44 -0700
 > committer Linus Torvalds <torvalds@g5.osdl.org> Fri, 23 Jun 2006 21:42:59 -0700
 > 
 > [PATCH] swsusp: add architecture special saveable pages support
 > 
 > 1. Add architecture specific pages save/restore support.  Next two patches
 >    will use this to save/restore 'ACPI NVS' pages.
 > 
 > 2. Allow reserved pages 'nosave'.  This could avoid save/restore BIOS
 >    reserved pages.
 > 
 > Signed-off-by: Shaohua Li <shaohua.li@intel.com>
 > Cc: Pavel Machek <pavel@ucw.cz>
 > Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
 > Cc: Nigel Cunningham <nigel@suspend2.net>
 > Signed-off-by: Andrew Morton <akpm@osdl.org>
 > Signed-off-by: Linus Torvalds <torvalds@osdl.org>

This breaks PPC compiles for me.

kernel/power/snapshot.c: In function 'save_arch_mem':
kernel/power/snapshot.c:93: error: implicit declaration of function 'kmap_atomic_pfn'
kernel/power/snapshot.c:93: warning: assignment makes pointer from integer without a cast

		Dave

-- 
http://www.codemonkey.org.uk

Re: [PATCH] swsusp: add architecture special saveable pages support

[Linus Torvalds]

On Sun, 25 Jun 2006, Dave Jones wrote:
> 
> This breaks PPC compiles for me.

Well, since Daniel Ritz reported that the following patch (that that patch 
was done in support of) also caused problems, I think we'll just have to 
revert that whole series. It's clearly not fully cooked.

		Linus