All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Petr Baudis <pasky@suse.cz>, git@vger.kernel.org
Subject: Re: [PATCH] Introduce Git.pm (v3)
Date: Tue, 27 Jun 2006 01:20:41 +0200	[thread overview]
Message-ID: <200606270120.42031.jnareb@gmail.com> (raw)
In-Reply-To: <20060623124539.GM21864@pasky.or.cz>

Dnia piątek 23. czerwca 2006 14:45, napisałeś:
> Dear diary, on Fri, Jun 23, 2006 at 08:03:23AM CEST, I got a letter
> where Jakub Narebski <jnareb@gmail.com> said that...
>> Perhaps Git.pm should provide also generic, pure Perl (and slower)
>> fallback implementation (when for some reason we cannot compile XS).
> 
> I fiercely want to avoid this if there is any other possible way to go
> about it - this is a path to hell of massive code duplication and
> additional work, as the number of routines will grow. If it is question
> of spending many developer-hours uselessly duplicating code in a way
> that'll be much slower than possible anyway OR building with -fPIC... ;-)

I have thought about reimplementing only the parts which are in XS. In C
one would probably write

#if can_asm
 asm (...)
#else
 /* C code equivalent */
#endif

In addition to allowing use of Git.pm for people who cannot compile 
Git.xs, it would be helpful I guess in Git.pm development.

-- 
Jakub Narebski
Poland

  reply	other threads:[~2006-06-26 23:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-22 22:02 [PATCH] Introduce Git.pm (v3) Petr Baudis
2006-06-22 23:18 ` Junio C Hamano
2006-06-22 23:50   ` Petr Baudis
2006-06-23  0:22     ` Junio C Hamano
2006-06-23  1:12       ` Petr Baudis
2006-06-23  4:41         ` Junio C Hamano
2006-06-23  6:03           ` Jakub Narebski
2006-06-23  6:34             ` Nguyễn Thái Ngọc Duy
2006-06-23 12:45             ` Petr Baudis
2006-06-26 23:20               ` Jakub Narebski [this message]
2006-06-23  8:57         ` Junio C Hamano
2006-06-23 12:04           ` Eric W. Biederman
2006-06-23 12:39           ` Petr Baudis
2006-06-24  0:39             ` Junio C Hamano
2006-06-24  1:01             ` Junio C Hamano
2006-06-24  1:07               ` Junio C Hamano
2006-06-24 20:10                 ` Johannes Schindelin
2006-06-25  1:20                   ` Junio C Hamano
2006-06-25  1:54                     ` Johannes Schindelin
2006-06-24  1:04             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200606270120.42031.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.