From: Junio C Hamano <junkio@cox.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Introduce Git.pm (v3)
Date: Sat, 24 Jun 2006 18:20:46 -0700 [thread overview]
Message-ID: <7vzmg2rpxt.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.63.0606242207510.29667@wbgn013.biozentrum.uni-wuerzburg.de> (Johannes Schindelin's message of "Sat, 24 Jun 2006 22:10:11 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> My original idea: on a machine where you have no accurate diff, you at
> least want to pass the tests, and you want to ensure you can apply a diff
> you generated on that machine.
I remember that, but I think recently we converted t4100 and
t4101 to use pregenerated test vectors so it might not be an
issue anymore?
> This patch is just compile tested, but obviously correct
Looks sane, thanks.
I would maybe rename the option to --inaccurate-eof and default
it to off (i.e. no --accurate-eof option). After all we are not
talking about arbitrary inaccuracy but the particular botch of
not having "\No newline at the end of file."
next prev parent reply other threads:[~2006-06-25 1:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-22 22:02 [PATCH] Introduce Git.pm (v3) Petr Baudis
2006-06-22 23:18 ` Junio C Hamano
2006-06-22 23:50 ` Petr Baudis
2006-06-23 0:22 ` Junio C Hamano
2006-06-23 1:12 ` Petr Baudis
2006-06-23 4:41 ` Junio C Hamano
2006-06-23 6:03 ` Jakub Narebski
2006-06-23 6:34 ` Nguyễn Thái Ngọc Duy
2006-06-23 12:45 ` Petr Baudis
2006-06-26 23:20 ` Jakub Narebski
2006-06-23 8:57 ` Junio C Hamano
2006-06-23 12:04 ` Eric W. Biederman
2006-06-23 12:39 ` Petr Baudis
2006-06-24 0:39 ` Junio C Hamano
2006-06-24 1:01 ` Junio C Hamano
2006-06-24 1:07 ` Junio C Hamano
2006-06-24 20:10 ` Johannes Schindelin
2006-06-25 1:20 ` Junio C Hamano [this message]
2006-06-25 1:54 ` Johannes Schindelin
2006-06-24 1:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzmg2rpxt.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.