From: Johann Lombardi <johann.lombardi@bull.net>
To: sho@tnes.nec.co.jp
Cc: adilger@clusterfs.com, cmm@us.ibm.com,
ext2-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/2] ext3: enlarge blocksize and fix rec_len overflow
Date: Wed, 28 Jun 2006 17:50:48 +0200 [thread overview]
Message-ID: <20060628155048.GG2893@chiva> (raw)
In-Reply-To: <20060628205238sho@rifu.tnes.nec.co.jp>
Hi Takashi,
> ext2/ext3_dir_entry_2 has a 16-bit entry(rec_len) and it would overflow
> with 64KB blocksize. This patch prevent from overflow by limiting
> rec_len to 65532.
In empty_dir(), offset is incremented by de->rec_len until it reaches
inode->i_size. I think bad things will happen with a 64kB blocksize since
the records no longer span the entire directory block.
AFAICS, there's a similar issue with bh->b_size in ext3_delete_entry().
Cheers,
Johann
next prev parent reply other threads:[~2006-06-28 15:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 11:52 [RFC 1/2] ext3: enlarge blocksize and fix rec_len overflow sho
2006-06-28 15:50 ` Johann Lombardi [this message]
2006-06-28 20:24 ` Andreas Dilger
2006-06-29 10:46 ` [Ext2-devel] [RFC 1/2] ext3: enlarge blocksize and fix rec_lenoverflow Takashi Sato
2006-06-29 16:30 ` Andreas Dilger
2006-06-29 18:10 ` [RFC 1/2] ext3: enlarge blocksize and fix rec_len overflow Daniel Phillips
2006-06-29 20:27 ` Andreas Dilger
2006-06-29 22:14 ` Daniel Phillips
2006-06-30 9:31 ` Johann Lombardi
2006-06-30 18:19 ` Daniel Phillips
2006-07-01 8:39 ` Andreas Dilger
2006-07-01 10:27 ` Michael Tokarev
2006-07-05 18:41 ` Daniel Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060628155048.GG2893@chiva \
--to=johann.lombardi@bull.net \
--cc=adilger@clusterfs.com \
--cc=cmm@us.ibm.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sho@tnes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.