All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nigel Cunningham <ncunningham@linuxmail.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux-pm mailing list <linux-pm@lists.osdl.org>,
	suspend2-devel@lists.suspend2.net
Subject: x86_64 restore_image declaration needs asmlinkage?
Date: Wed, 28 Jun 2006 20:48:34 +1000	[thread overview]
Message-ID: <200606282048.38746.ncunningham@linuxmail.org> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 871 bytes --]

Hi.

I received a report of problems with CONFIG_REGPARM and suspending, that led 
me to recheck asm calls and declarations. Not being a guru on these things, I 
want to ask advice from those who know more.

Along the way I noticed that current git has:

extern asmlinkage int swsusp_arch_suspend(void);
extern asmlinkage int swsusp_arch_resume(void);

This is right for x86, but for x86_64, we actually call a C routine in 
arch/x86_64/kernel/suspend.c, which calls restore_image in 
arch/x86_64/kernel/suspend_asm.S. Restore image is declared in suspend.c as 

extern int restore_image(void);

should it be:

extern asmlinkage int restore_image(void);

Having swsusp_arch_resume declared as asmlinkage doesn't matter, does it?

Regards,

Nigel
-- 
Nigel, Michelle and Alisdair Cunningham
5 Mitchell Street
Cobden 3266
Victoria, Australia

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Suspend2-devel mailing list
Suspend2-devel@lists.suspend2.net
http://lists.suspend2.net/mailman/listinfo/suspend2-devel

WARNING: multiple messages have this Message-ID (diff)
From: Nigel Cunningham <ncunningham@linuxmail.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Linux-pm mailing list" <linux-pm@lists.osdl.org>,
	suspend2-devel@lists.suspend2.net
Subject: x86_64 restore_image declaration needs asmlinkage?
Date: Wed, 28 Jun 2006 20:48:34 +1000	[thread overview]
Message-ID: <200606282048.38746.ncunningham@linuxmail.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

Hi.

I received a report of problems with CONFIG_REGPARM and suspending, that led 
me to recheck asm calls and declarations. Not being a guru on these things, I 
want to ask advice from those who know more.

Along the way I noticed that current git has:

extern asmlinkage int swsusp_arch_suspend(void);
extern asmlinkage int swsusp_arch_resume(void);

This is right for x86, but for x86_64, we actually call a C routine in 
arch/x86_64/kernel/suspend.c, which calls restore_image in 
arch/x86_64/kernel/suspend_asm.S. Restore image is declared in suspend.c as 

extern int restore_image(void);

should it be:

extern asmlinkage int restore_image(void);

Having swsusp_arch_resume declared as asmlinkage doesn't matter, does it?

Regards,

Nigel
-- 
Nigel, Michelle and Alisdair Cunningham
5 Mitchell Street
Cobden 3266
Victoria, Australia

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

             reply	other threads:[~2006-06-28 10:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-28 10:48 Nigel Cunningham [this message]
2006-06-28 10:48 ` x86_64 restore_image declaration needs asmlinkage? Nigel Cunningham
2006-06-28 11:53 ` Rafael J. Wysocki
2006-06-28 11:53   ` Rafael J. Wysocki
2006-06-28 12:00   ` Nigel Cunningham
2006-06-28 12:10     ` Rafael J. Wysocki
2006-06-28 12:10       ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200606282048.38746.ncunningham@linuxmail.org \
    --to=ncunningham@linuxmail.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=suspend2-devel@lists.suspend2.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.