Re: [PATCH] chardev: GPIO for SCx200 & PC-8736x: add proper Kconfig, Makefile entries

Re: [PATCH] chardev: GPIO for SCx200 & PC-8736x: add proper Kconfig, Makefile entries

[Dave Jones]

On Wed, Jun 28, 2006 at 02:01:24AM +0000, Linux Kernel wrote:
 > commit 7a8e2a5ea4cf43c0edd6db56a156549edb0eee98
 > tree 42a88e7f8de0c22011b8e75fb96255e5360380d8
 > parent 23916a8e3d8f41aa91474e834ac99808b197c39e
 > author Jim Cromie <jim.cromie@gmail.com> Tue, 27 Jun 2006 16:54:27 -0700
 > committer Linus Torvalds <torvalds@g5.osdl.org> Wed, 28 Jun 2006 07:32:43 -0700
 > 
 > [PATCH] chardev: GPIO for SCx200 & PC-8736x: add proper Kconfig, Makefile entries
 > 
 > Replace the temp makefile hacks with proper CONFIG entries, which are also
 > added to Kconfig.
 >  ....
 > +
 > +config NSC_GPIO
 > +	tristate "NatSemi Base GPIO Support"
 > +	# selected by SCx200_GPIO and PC8736x_GPIO
 > +	# what about 2 selectors differing: m != y
 > +	help
 > +	  Common support used (and needed) by scx200_gpio and
 > +	  pc8736x_gpio drivers.  If those drivers are built as
 > +	  modules, this one will be too, named nsc_gpio
 
AFAICT, this is x86 only, so the patch below is needed to stop
this new option showing up on PPC, IA64, etc..

Signed-off-by: Dave Jones <davej@redhat.com>

--- linux-2.6.17.noarch/drivers/char/Kconfig~	2006-06-29 01:17:35.000000000 -0400
+++ linux-2.6.17.noarch/drivers/char/Kconfig	2006-06-29 01:17:55.000000000 -0400
@@ -963,6 +963,7 @@ config PC8736x_GPIO
 
 config NSC_GPIO
 	tristate "NatSemi Base GPIO Support"
+	depends on X86_32
 	# selected by SCx200_GPIO and PC8736x_GPIO
 	# what about 2 selectors differing: m != y
 	help

-- 
http://www.codemonkey.org.uk