All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Lucas <clucas@rotomalug.org>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] entry in TODO List
Date: Fri, 30 Jun 2006 09:43:37 +0000	[thread overview]
Message-ID: <20060630094337.GD12178@rotomalug.org> (raw)

Hi,

Sorry if it is a mistake: but do we must do the same work on 
- Use dev_set_drvdata to set dev->driver_data
  ...
as :
- Use pci_set_drvdata() to set dev->driver_data, likewise use
  pci_get_drvdata()
  instead of reading directly.
  -   dev->driver_data = pcigame;
  +   pci_set_drvdata(dev, pcigame);

Few words more act... Does this patch is correct ?


Index: linux-2.6.17.2/drivers/net/tulip/de4x5.c
=================================--- linux-2.6.17.2.orig/drivers/net/tulip/de4x5.c	2006-06-30 11:41:37.000000000 +0200
+++ linux-2.6.17.2/drivers/net/tulip/de4x5.c	2006-06-30 11:42:38.000000000 +0200
@@ -1090,7 +1090,7 @@
     struct pci_dev *pdev = NULL;
     int i, status=0;
 
-    gendev->driver_data = dev;
+    dev_set_drvdata(gendev, dev);
 
     /* Ensure we're not sleeping */
     if (lp->bus = EISA) {
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

                 reply	other threads:[~2006-06-30  9:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060630094337.GD12178@rotomalug.org \
    --to=clucas@rotomalug.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.