* [2.6 patch] EXPORT_UNUSED_SYMBOL{,GPL} {,un}register_die_notifier
@ 2006-06-30 11:33 Adrian Bunk
2006-07-01 3:35 ` Andrew Morton
2006-07-02 6:09 ` Keith Owens
0 siblings, 2 replies; 7+ messages in thread
From: Adrian Bunk @ 2006-06-30 11:33 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
This patch marks {,un}register_die_notifier as
EXPORT_UNUSED_SYMBOL{,GPL}.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
arch/i386/kernel/traps.c | 4 ++--
arch/ia64/kernel/traps.c | 4 ++--
arch/powerpc/kernel/traps.c | 4 ++--
arch/sparc64/kernel/traps.c | 4 ++--
arch/x86_64/kernel/traps.c | 4 ++--
5 files changed, 10 insertions(+), 10 deletions(-)
--- linux-2.6.17-mm4-full/arch/i386/kernel/traps.c.old 2006-06-30 04:06:31.000000000 +0200
+++ linux-2.6.17-mm4-full/arch/i386/kernel/traps.c 2006-06-30 04:07:26.000000000 +0200
@@ -101,13 +101,13 @@
vmalloc_sync_all();
return atomic_notifier_chain_register(&i386die_chain, nb);
}
-EXPORT_SYMBOL(register_die_notifier);
+EXPORT_UNUSED_SYMBOL(register_die_notifier); /* June 2006 */
int unregister_die_notifier(struct notifier_block *nb)
{
return atomic_notifier_chain_unregister(&i386die_chain, nb);
}
-EXPORT_SYMBOL(unregister_die_notifier);
+EXPORT_UNUSED_SYMBOL(unregister_die_notifier); /* June 2006 */
static inline int valid_stack_ptr(struct thread_info *tinfo, void *p)
{
--- linux-2.6.17-mm4-full/arch/ia64/kernel/traps.c.old 2006-06-30 04:07:35.000000000 +0200
+++ linux-2.6.17-mm4-full/arch/ia64/kernel/traps.c 2006-06-30 04:09:20.000000000 +0200
@@ -37,14 +37,14 @@
{
return atomic_notifier_chain_register(&ia64die_chain, nb);
}
-EXPORT_SYMBOL_GPL(register_die_notifier);
+EXPORT_UNUSED_SYMBOL_GPL(register_die_notifier); /* June 2006 */
int
unregister_die_notifier(struct notifier_block *nb)
{
return atomic_notifier_chain_unregister(&ia64die_chain, nb);
}
-EXPORT_SYMBOL_GPL(unregister_die_notifier);
+EXPORT_UNUSED_SYMBOL_GPL(unregister_die_notifier); /* June 2006 */
void __init
trap_init (void)
--- linux-2.6.17-mm4-full/arch/powerpc/kernel/traps.c.old 2006-06-30 04:09:35.000000000 +0200
+++ linux-2.6.17-mm4-full/arch/powerpc/kernel/traps.c 2006-06-30 04:11:35.000000000 +0200
@@ -85,13 +85,13 @@
{
return atomic_notifier_chain_register(&powerpc_die_chain, nb);
}
-EXPORT_SYMBOL(register_die_notifier);
+EXPORT_UNUSED_SYMBOL(register_die_notifier); /* June 2006 */
int unregister_die_notifier(struct notifier_block *nb)
{
return atomic_notifier_chain_unregister(&powerpc_die_chain, nb);
}
-EXPORT_SYMBOL(unregister_die_notifier);
+EXPORT_UNUSED_SYMBOL(unregister_die_notifier); /* June 2006 */
/*
* Trap & Exception support
--- linux-2.6.17-mm4-full/arch/sparc64/kernel/traps.c.old 2006-06-30 04:11:46.000000000 +0200
+++ linux-2.6.17-mm4-full/arch/sparc64/kernel/traps.c 2006-06-30 04:12:11.000000000 +0200
@@ -50,13 +50,13 @@
{
return atomic_notifier_chain_register(&sparc64die_chain, nb);
}
-EXPORT_SYMBOL(register_die_notifier);
+EXPORT_UNUSED_SYMBOL(register_die_notifier); /* June 2006 */
int unregister_die_notifier(struct notifier_block *nb)
{
return atomic_notifier_chain_unregister(&sparc64die_chain, nb);
}
-EXPORT_SYMBOL(unregister_die_notifier);
+EXPORT_UNUSED_SYMBOL(unregister_die_notifier); /* June 2006 */
/* When an irrecoverable trap occurs at tl > 0, the trap entry
* code logs the trap state registers at every level in the trap
--- linux-2.6.17-mm4-full/arch/x86_64/kernel/traps.c.old 2006-06-30 04:12:18.000000000 +0200
+++ linux-2.6.17-mm4-full/arch/x86_64/kernel/traps.c 2006-06-30 04:12:48.000000000 +0200
@@ -77,13 +77,13 @@
vmalloc_sync_all();
return atomic_notifier_chain_register(&die_chain, nb);
}
-EXPORT_SYMBOL(register_die_notifier);
+EXPORT_UNUSED_SYMBOL(register_die_notifier); /* June 2006 */
int unregister_die_notifier(struct notifier_block *nb)
{
return atomic_notifier_chain_unregister(&die_chain, nb);
}
-EXPORT_SYMBOL(unregister_die_notifier);
+EXPORT_UNUSED_SYMBOL(unregister_die_notifier); /* June 2006 */
static inline void conditional_sti(struct pt_regs *regs)
{
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [2.6 patch] EXPORT_UNUSED_SYMBOL{,GPL} {,un}register_die_notifier
2006-06-30 11:33 [2.6 patch] EXPORT_UNUSED_SYMBOL{,GPL} {,un}register_die_notifier Adrian Bunk
@ 2006-07-01 3:35 ` Andrew Morton
2006-07-01 11:54 ` Alan Cox
2006-07-11 14:04 ` Dean Nelson
2006-07-02 6:09 ` Keith Owens
1 sibling, 2 replies; 7+ messages in thread
From: Andrew Morton @ 2006-07-01 3:35 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
On Fri, 30 Jun 2006 13:33:17 +0200
Adrian Bunk <bunk@stusta.de> wrote:
> -EXPORT_SYMBOL(register_die_notifier);
> +EXPORT_UNUSED_SYMBOL(register_die_notifier); /* June 2006 */
> -EXPORT_SYMBOL(unregister_die_notifier);
> +EXPORT_UNUSED_SYMBOL(unregister_die_notifier); /* June 2006 */
I'd expect there are any number of low-level debugging quick-hacky modules
around which want to hook into here.
We can try it I guess, but I expect we'll hear about it.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [2.6 patch] EXPORT_UNUSED_SYMBOL{,GPL} {,un}register_die_notifier
2006-07-01 3:35 ` Andrew Morton
@ 2006-07-01 11:54 ` Alan Cox
2006-07-01 11:42 ` Arjan van de Ven
2006-07-11 14:04 ` Dean Nelson
1 sibling, 1 reply; 7+ messages in thread
From: Alan Cox @ 2006-07-01 11:54 UTC (permalink / raw)
To: Andrew Morton; +Cc: Adrian Bunk, linux-kernel
Ar Gwe, 2006-06-30 am 20:35 -0700, ysgrifennodd Andrew Morton:
> On Fri, 30 Jun 2006 13:33:17 +0200
> Adrian Bunk <bunk@stusta.de> wrote:
>
> > -EXPORT_SYMBOL(register_die_notifier);
> > +EXPORT_UNUSED_SYMBOL(register_die_notifier); /* June 2006 */
> > -EXPORT_SYMBOL(unregister_die_notifier);
> > +EXPORT_UNUSED_SYMBOL(unregister_die_notifier); /* June 2006 */
>
> I'd expect there are any number of low-level debugging quick-hacky modules
> around which want to hook into here.
>
> We can try it I guess, but I expect we'll hear about it.
Some of the cluster modules use it too for fast failover.
Alan
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [2.6 patch] EXPORT_UNUSED_SYMBOL{,GPL} {,un}register_die_notifier
2006-07-01 11:54 ` Alan Cox
@ 2006-07-01 11:42 ` Arjan van de Ven
0 siblings, 0 replies; 7+ messages in thread
From: Arjan van de Ven @ 2006-07-01 11:42 UTC (permalink / raw)
To: Alan Cox; +Cc: Andrew Morton, Adrian Bunk, linux-kernel
On Sat, 2006-07-01 at 12:54 +0100, Alan Cox wrote:
> Ar Gwe, 2006-06-30 am 20:35 -0700, ysgrifennodd Andrew Morton:
> > On Fri, 30 Jun 2006 13:33:17 +0200
> > Adrian Bunk <bunk@stusta.de> wrote:
> >
> > > -EXPORT_SYMBOL(register_die_notifier);
> > > +EXPORT_UNUSED_SYMBOL(register_die_notifier); /* June 2006 */
> > > -EXPORT_SYMBOL(unregister_die_notifier);
> > > +EXPORT_UNUSED_SYMBOL(unregister_die_notifier); /* June 2006 */
> >
> > I'd expect there are any number of low-level debugging quick-hacky modules
> > around which want to hook into here.
> >
> > We can try it I guess, but I expect we'll hear about it.
>
> Some of the cluster modules use it too for fast failover.
which ones?
the gfs ones are in -mm and aren't using it...
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6 patch] EXPORT_UNUSED_SYMBOL{,GPL} {,un}register_die_notifier
2006-07-01 3:35 ` Andrew Morton
2006-07-01 11:54 ` Alan Cox
@ 2006-07-11 14:04 ` Dean Nelson
1 sibling, 0 replies; 7+ messages in thread
From: Dean Nelson @ 2006-07-11 14:04 UTC (permalink / raw)
To: Andrew Morton; +Cc: bunk, linux-kernel
On Fri, Jun 30, 2006 at 08:35:46PM -0700, Andrew Morton wrote:
> On Fri, 30 Jun 2006 13:33:17 +0200
> Adrian Bunk <bunk@stusta.de> wrote:
>
> > -EXPORT_SYMBOL(register_die_notifier);
> > +EXPORT_UNUSED_SYMBOL(register_die_notifier); /* June 2006 */
> > -EXPORT_SYMBOL(unregister_die_notifier);
> > +EXPORT_UNUSED_SYMBOL(unregister_die_notifier); /* June 2006 */
>
> I'd expect there are any number of low-level debugging quick-hacky modules
> around which want to hook into here.
>
> We can try it I guess, but I expect we'll hear about it.
The XPC module, which is in the community tree, references both symbols.
See arch/ia64/sn/kernel/xpc_main.c for details.
Dean
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6 patch] EXPORT_UNUSED_SYMBOL{,GPL} {,un}register_die_notifier
2006-06-30 11:33 [2.6 patch] EXPORT_UNUSED_SYMBOL{,GPL} {,un}register_die_notifier Adrian Bunk
2006-07-01 3:35 ` Andrew Morton
@ 2006-07-02 6:09 ` Keith Owens
2006-07-02 7:38 ` Arjan van de Ven
1 sibling, 1 reply; 7+ messages in thread
From: Keith Owens @ 2006-07-02 6:09 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel
Adrian Bunk (on Fri, 30 Jun 2006 13:33:17 +0200) wrote:
>This patch marks {,un}register_die_notifier as
>EXPORT_UNUSED_SYMBOL{,GPL}.
KDB needs that.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [2.6 patch] EXPORT_UNUSED_SYMBOL{,GPL} {,un}register_die_notifier
2006-07-02 6:09 ` Keith Owens
@ 2006-07-02 7:38 ` Arjan van de Ven
0 siblings, 0 replies; 7+ messages in thread
From: Arjan van de Ven @ 2006-07-02 7:38 UTC (permalink / raw)
To: Keith Owens; +Cc: Adrian Bunk, Andrew Morton, linux-kernel
On Sun, 2006-07-02 at 16:09 +1000, Keith Owens wrote:
> Adrian Bunk (on Fri, 30 Jun 2006 13:33:17 +0200) wrote:
> >This patch marks {,un}register_die_notifier as
> >EXPORT_UNUSED_SYMBOL{,GPL}.
>
> KDB needs that.
is kdb is strict module or does it need extra patches anyway?
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2006-07-11 14:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-30 11:33 [2.6 patch] EXPORT_UNUSED_SYMBOL{,GPL} {,un}register_die_notifier Adrian Bunk
2006-07-01 3:35 ` Andrew Morton
2006-07-01 11:54 ` Alan Cox
2006-07-01 11:42 ` Arjan van de Ven
2006-07-11 14:04 ` Dean Nelson
2006-07-02 6:09 ` Keith Owens
2006-07-02 7:38 ` Arjan van de Ven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.