[PATCH] iptables trivial compile warning cleanup

[PATCH] iptables trivial compile warning cleanup

[Phil Oester]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

Cleanup a few compile warnings in latest snapshot:

extensions/libipt_dscp_helper.c:69: warning: 'dscp_to_name' defined but not used
extensions/libipt_sctp.c: In function 'print_chunks':
extensions/libipt_sctp.c:465: warning: value computed is not used
extensions/libipt_sctp.c:477: warning: value computed is not used

Resolves bug #457.

Phil



[-- Attachment #2: patch-compilewarn --]
[-- Type: text/plain, Size: 1016 bytes --]

diff -ru ipt-orig/extensions/libipt_dscp_helper.c ipt-new/extensions/libipt_dscp_helper.c
--- ipt-orig/extensions/libipt_dscp_helper.c	2002-08-26 06:09:40.000000000 -0700
+++ ipt-new/extensions/libipt_dscp_helper.c	2006-06-30 13:44:49.000000000 -0700
@@ -63,7 +63,7 @@
 }
 
 
-
+#if 0
 static const char *
 dscp_to_name(unsigned int dscp)
 {
@@ -78,5 +78,5 @@
 	exit_error(PARAMETER_PROBLEM,
 			"Invalid DSCP value `%d'\n", dscp);
 }
-
+#endif
 
diff -ru ipt-orig/extensions/libipt_sctp.c ipt-new/extensions/libipt_sctp.c
--- ipt-orig/extensions/libipt_sctp.c	2006-02-01 04:58:28.000000000 -0800
+++ ipt-new/extensions/libipt_sctp.c	2006-06-30 13:47:38.000000000 -0700
@@ -462,7 +462,8 @@
 	flag = 0;
 	for (i = 0; i < 256; i++) {
 		if (SCTP_CHUNKMAP_IS_SET(chunkmap, i)) {
-			flag && printf(",");
+			if (flag)
+				printf(",");
 			flag = 1;
 			print_chunk(i, numeric);
 			for (j = 0; j < flag_count; j++) {
@@ -474,7 +475,8 @@
 		}
 	}
 
-	flag && printf(" ");
+	if (flag)
+		printf(" ");
 out:
 	return;
 }

Re: [PATCH] iptables trivial compile warning cleanup

[Patrick McHardy]

Phil Oester wrote:
> Cleanup a few compile warnings in latest snapshot:
> 
> extensions/libipt_dscp_helper.c:69: warning: 'dscp_to_name' defined but not used
> extensions/libipt_sctp.c: In function 'print_chunks':
> extensions/libipt_sctp.c:465: warning: value computed is not used
> extensions/libipt_sctp.c:477: warning: value computed is not used
> 
> Resolves bug #457.

Applied, thanks Phil.