From: Vincent Hanquez <vincent.hanquez@cl.cam.ac.uk>
To: Jeremy Katz <katzj@redhat.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] libxenstore should be executable
Date: Tue, 4 Jul 2006 11:57:49 +0200 [thread overview]
Message-ID: <20060704095749.GA6997@snarc.org> (raw)
In-Reply-To: <1151983683.20228.25.camel@aglarond.local>
On Mon, Jul 03, 2006 at 11:28:03PM -0400, Jeremy Katz wrote:
> Shared libraries are supposed to be installed +x
>
> Signed-off-by: Jeremy Katz <katzj@redhat.com>
>
> Jeremy
> diff -r fd6d12935b56 tools/xenstore/Makefile
> --- a/tools/xenstore/Makefile Mon Jul 03 16:07:20 2006 +0100
> +++ b/tools/xenstore/Makefile Mon Jul 03 23:26:44 2006 -0400
> @@ -171,7 +171,7 @@ install: all
> $(INSTALL_PROG) xenstore-control $(DESTDIR)/usr/bin
> $(INSTALL_PROG) xenstore-ls $(DESTDIR)/usr/bin
> $(INSTALL_DIR) -p $(DESTDIR)/usr/$(LIBDIR)
> - $(INSTALL_DATA) libxenstore.so $(DESTDIR)/usr/$(LIBDIR)
> + $(INSTALL_PROG) libxenstore.so $(DESTDIR)/usr/$(LIBDIR)
> $(INSTALL_DATA) xs.h $(DESTDIR)/usr/include
> $(INSTALL_DATA) xs_lib.h $(DESTDIR)/usr/include
I don't think that needed (almost all libraries in my /usr/lib are -x).
Even then you shouldn't call INSTALL_**PROG** but just create an
INSTALL_LIB or somethign similar..
--
Vincent Hanquez
next prev parent reply other threads:[~2006-07-04 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-04 3:28 [PATCH] libxenstore should be executable Jeremy Katz
2006-07-04 6:51 ` Bastian Blank
2006-07-04 9:57 ` Vincent Hanquez [this message]
2006-07-05 18:36 ` Jeremy Katz
2006-07-11 12:30 ` Horms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060704095749.GA6997@snarc.org \
--to=vincent.hanquez@cl.cam.ac.uk \
--cc=katzj@redhat.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.