[PATCH] ACPI: disable SBS by default

[PATCH] ACPI: disable SBS by default

[Dmitry Torokhov]

From: Dmitry Torokhov <dtor@insightbb.com>

ACPI: disable SBS by default

Kconfig help even says that SBS is pretty rare and already
obsolete so it does not make sence to keep it enabled.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---

 drivers/acpi/Kconfig |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: work/drivers/acpi/Kconfig
===================================================================
--- work.orig/drivers/acpi/Kconfig
+++ work/drivers/acpi/Kconfig
@@ -357,7 +357,7 @@ config ACPI_SBS
 	tristate "Smart Battery System (EXPERIMENTAL)"
 	depends on X86 && I2C
 	depends on EXPERIMENTAL
-	default y
+	default n
 	help
 	  This driver adds support for the Smart Battery System.
 	  Depends on I2C (Device Drivers ---> I2C support)

Re: [PATCH] ACPI: disable SBS by default

[Fryderyk Dziarmagowski]

--- Dmitry Torokhov <dtor@insightbb.com> wrote:

> From: Dmitry Torokhov <dtor@insightbb.com>
> 
> ACPI: disable SBS by default
> 
> Kconfig help even says that SBS is pretty rare and already
> obsolete so it does not make sence to keep it enabled.

it is not rare (see SBS related trafic on this list in last weeks and
even months).
How can it be already obsolete? What is a replacement for that driver?

-- 
Fryderyk Dziarmagowski

Re: [PATCH] ACPI: disable SBS by default

[Dmitry Torokhov]

On 7/6/06, Fryderyk Dziarmagowski <freetz@gmx.net> wrote:
> --- Dmitry Torokhov <dtor@insightbb.com> wrote:
>
> > From: Dmitry Torokhov <dtor@insightbb.com>
> >
> > ACPI: disable SBS by default
> >
> > Kconfig help even says that SBS is pretty rare and already
> > obsolete so it does not make sence to keep it enabled.
>
> it is not rare (see SBS related trafic on this list in last weeks and
> even months).
> How can it be already obsolete? What is a replacement for that driver?
>

I am relying on author's description here. Here is what Kconfig help says:

"This driver adds support for the Smart Battery System. Depends on I2C
(Device Drivers ---> I2C support). A "Smart Battery" is quite old and
quite rare compared to today's ACPI "Control Method" battery."

Note that "quite old and rare". Besides, the patch does not remove the
driver, it just makes it not enabled in default build as not every box
has an SBS.

-- 
Dmitry