[Drbd-dev] Minor fix to DRBD install target...

* [Drbd-dev] Minor fix to DRBD install target...
@ 2006-07-06 19:16 Graham, Simon
  0 siblings, 0 replies; 5+ messages in thread
From: Graham, Simon @ 2006-07-06 19:16 UTC (permalink / raw)
  To: drbd-dev

[-- Attachment #1: Type: text/plain, Size: 1856 bytes --]

I've noticed that when I do a 'make install' to build drbd with PREFIX
set to something other than '/', the drbd.ko file ends up in
lib/modules/<kernel>/block/drbd.ko whereas if I do a 'make install' on
the target system with no PREFIX, the file ends up in
lib/modules/<kernel>/kernel/drivers/block/drbd.ko - this has been
annoying me because our standard system install is based on files
generated by the first whereas if I then make a change and go to update
an installed system it uses the second and I end up with two copies of
drbd.ko on the system - weirdness then ensues!

I think the problem is in drbd/drbd/Makefile in the install target -
when figuring out the location to put the module, it uses:

    MODSUBDIR := $(strip \
      $(if $(wildcard lib/modules/$(KERNELRELEASE)/kernel),\
           kernel/drivers/block,\
           block))
    LINUX := $(wildcard lib/modules/$(KERNELRELEASE)/build)

Since I build on a system running a different kernel, MODSUBDIR ends up
being just 'block' - I think both of these variable assignments should
have $(PREFIX) on the front (and it certainly seems to work better for
me when I do this). DRBD 0.7.20 patch follows - 0.8 is identical.

/simgr

===================================================================

--- Makefile	(revision 2917)
+++ Makefile	(working copy)
@@ -150,10 +150,10 @@
     MODOBJ-6 := drbd.ko
     MODOBJ   := $(MODOBJ-$(PATCHLEVEL))
     MODSUBDIR := $(strip \
-      $(if $(wildcard /lib/modules/$(KERNELRELEASE)/kernel),\
+      $(if $(wildcard $(PREFIX)/lib/modules/$(KERNELRELEASE)/kernel),\
            kernel/drivers/block,\
            block))
-    LINUX := $(wildcard /lib/modules/$(KERNELRELEASE)/build)
+    LINUX := $(wildcard $(PREFIX)/lib/modules/$(KERNELRELEASE)/build)
 
     install:
 	@if ! [ -e $(MODOBJ) ] ; then \

[-- Attachment #2: Type: text/html, Size: 7104 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread