* [PATCH] fix irq_chip struct for Pb1200/Db1200 platform
@ 2006-07-14 14:53 Daniel Mack
2006-07-14 16:11 ` Ralf Baechle
0 siblings, 1 reply; 9+ messages in thread
From: Daniel Mack @ 2006-07-14 14:53 UTC (permalink / raw)
To: linux-mips
Hi,
the following patch makes external interrupt sources work again
on AMD's Au1200 development boards. The unnamed initialization
of 'external_irq_type' lead to a defective function mapping.
I resent it because of the missing Signed-off-by: line, sorry.
Daniel
Signed-off-by: Daniel Mack <daniel@caiaq.de>
--- a/arch/mips/au1000/pb1200/irqmap.c
+++ b/arch/mips/au1000/pb1200/irqmap.c
@@ -151,18 +151,17 @@ static void pb1200_end_irq(unsigned int
static struct irq_chip external_irq_type =
{
#ifdef CONFIG_MIPS_PB1200
- "Pb1200 Ext",
+ .name = "Pb1200 Ext",
#endif
#ifdef CONFIG_MIPS_DB1200
- "Db1200 Ext",
+ .name = "Db1200 Ext",
#endif
- pb1200_startup_irq,
- pb1200_shutdown_irq,
- pb1200_enable_irq,
- pb1200_disable_irq,
- pb1200_mask_and_ack_irq,
- pb1200_end_irq,
- NULL
+ .startup = pb1200_startup_irq,
+ .shutdown = pb1200_shutdown_irq,
+ .enable = pb1200_enable_irq,
+ .disable = pb1200_disable_irq,
+ .mask_ack = pb1200_mask_and_ack_irq,
+ .end = pb1200_end_irq
};
void _board_init_irq(void)
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] fix irq_chip struct for Pb1200/Db1200 platform
2006-07-14 14:53 [PATCH] fix irq_chip struct for Pb1200/Db1200 platform Daniel Mack
@ 2006-07-14 16:11 ` Ralf Baechle
2006-07-15 0:57 ` Daniel Mack
0 siblings, 1 reply; 9+ messages in thread
From: Ralf Baechle @ 2006-07-14 16:11 UTC (permalink / raw)
To: Daniel Mack; +Cc: linux-mips
On Fri, Jul 14, 2006 at 04:53:11PM +0200, Daniel Mack wrote:
> the following patch makes external interrupt sources work again
> on AMD's Au1200 development boards. The unnamed initialization
> of 'external_irq_type' lead to a defective function mapping.
>
> I resent it because of the missing Signed-off-by: line, sorry.
Good - but this patch is still corrupted so doesn't apply, can you
resend with a non-broken mailer?
Ralf
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] fix irq_chip struct for Pb1200/Db1200 platform
2006-07-14 16:11 ` Ralf Baechle
@ 2006-07-15 0:57 ` Daniel Mack
2006-07-15 4:39 ` Ralf Baechle
0 siblings, 1 reply; 9+ messages in thread
From: Daniel Mack @ 2006-07-15 0:57 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips
On Fri, Jul 14, 2006 at 05:11:28PM +0100, Ralf Baechle wrote:
> > the following patch makes external interrupt sources work again
> > on AMD's Au1200 development boards. The unnamed initialization
> > of 'external_irq_type' lead to a defective function mapping.
> >
> > I resent it because of the missing Signed-off-by: line, sorry.
>
> Good - but this patch is still corrupted so doesn't apply, can you
> resend with a non-broken mailer?
It hasn't been line-wrapped or corrupted by my mailer, as one can
see in the mailing list's web archive.
Anyway, I put it online as a plain text file so anybody should be
able to use it properly:
http://caiaq.org/linux-mips/patches/irq_chip_pb1200.patch
Daniel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] fix irq_chip struct for Pb1200/Db1200 platform
2006-07-15 0:57 ` Daniel Mack
@ 2006-07-15 4:39 ` Ralf Baechle
2006-07-15 9:16 ` Daniel Mack
0 siblings, 1 reply; 9+ messages in thread
From: Ralf Baechle @ 2006-07-15 4:39 UTC (permalink / raw)
To: Daniel Mack; +Cc: linux-mips
On Sat, Jul 15, 2006 at 02:57:47AM +0200, Daniel Mack wrote:
> Date: Sat, 15 Jul 2006 02:57:47 +0200
> From: Daniel Mack <daniel@yoobay.net>
> To: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> Subject: Re: [PATCH] fix irq_chip struct for Pb1200/Db1200 platform
> Content-Type: text/plain; charset=us-ascii
>
> On Fri, Jul 14, 2006 at 05:11:28PM +0100, Ralf Baechle wrote:
> > > the following patch makes external interrupt sources work again
> > > on AMD's Au1200 development boards. The unnamed initialization
> > > of 'external_irq_type' lead to a defective function mapping.
> > >
> > > I resent it because of the missing Signed-off-by: line, sorry.
> >
> > Good - but this patch is still corrupted so doesn't apply, can you
> > resend with a non-broken mailer?
>
> It hasn't been line-wrapped or corrupted by my mailer, as one can
> see in the mailing list's web archive.
Same corrupt stuff:
$ wget http://caiaq.org/linux-mips/patches/irq_chip_pb1200.patch
--05:36:02-- http://caiaq.org/linux-mips/patches/irq_chip_pb1200.patch
=> `irq_chip_pb1200.patch'
Resolving caiaq.org... 212.112.241.133
Connecting to caiaq.org|212.112.241.133|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 1,057 (1.0K) [text/plain]
100%[====================================>] 1,057 --.--K/s
05:36:02 (77.54 MB/s) - `irq_chip_pb1200.patch' saved [1057/1057]
$ patch -p1 < irq_chip_pb1200.patch
patching file arch/mips/au1000/pb1200/irqmap.c
patch: **** malformed patch at line 15: static struct irq_chip external_irq_type =
$
Ralf
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] fix irq_chip struct for Pb1200/Db1200 platform
@ 2006-07-14 14:46 Daniel Mack
0 siblings, 0 replies; 9+ messages in thread
From: Daniel Mack @ 2006-07-14 14:46 UTC (permalink / raw)
To: linux-mips
Hi,
the following patch makes external interrupt sources work again
on AMD's Au1200 development boards. The unnamed initialization
of 'external_irq_type' lead to a defective function mapping.
Daniel
--- a/arch/mips/au1000/pb1200/irqmap.c
+++ b/arch/mips/au1000/pb1200/irqmap.c
@@ -151,18 +151,17 @@ static void pb1200_end_irq(unsigned int
static struct irq_chip external_irq_type =
{
#ifdef CONFIG_MIPS_PB1200
- "Pb1200 Ext",
+ .name = "Pb1200 Ext",
#endif
#ifdef CONFIG_MIPS_DB1200
- "Db1200 Ext",
+ .name = "Db1200 Ext",
#endif
- pb1200_startup_irq,
- pb1200_shutdown_irq,
- pb1200_enable_irq,
- pb1200_disable_irq,
- pb1200_mask_and_ack_irq,
- pb1200_end_irq,
- NULL
+ .startup = pb1200_startup_irq,
+ .shutdown = pb1200_shutdown_irq,
+ .enable = pb1200_enable_irq,
+ .disable = pb1200_disable_irq,
+ .mask_ack = pb1200_mask_and_ack_irq,
+ .end = pb1200_end_irq
};
void _board_init_irq(void)
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2006-08-29 17:59 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-14 14:53 [PATCH] fix irq_chip struct for Pb1200/Db1200 platform Daniel Mack
2006-07-14 16:11 ` Ralf Baechle
2006-07-15 0:57 ` Daniel Mack
2006-07-15 4:39 ` Ralf Baechle
2006-07-15 9:16 ` Daniel Mack
2006-07-27 2:32 ` Daniel Mack
2006-08-04 8:27 ` Domen Puncer
2006-08-29 17:59 ` Daniel Mack
-- strict thread matches above, loose matches on Subject: below --
2006-07-14 14:46 Daniel Mack
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.