From: Andi Kleen <ak@suse.de>
To: Horms <horms@verge.net.au>
Cc: Russell King <rmk@arm.linux.org.uk>,
Tony Luck <tony.luck@intel.com>,
Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
Chris Zankel <chris@zankel.net>, Andrew Morton <akpm@osdl.org>,
linux-ia64@vger.kernel.org, linuxppc-dev@ozlabs.org,
discuss@x86-64.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] panic_on_oops: remove ssleep()
Date: Mon, 17 Jul 2006 22:27:51 +0000 [thread overview]
Message-ID: <200607180027.51986.ak@suse.de> (raw)
In-Reply-To: <31687.FP.7244@verge.net.au>
On Monday 17 July 2006 18:17, Horms wrote:
> This patch is part of an effort to unify the panic_on_oops behaviour
> across all architectures that implement it.
>
> It was pointed out to me by Andi Kleen that if an oops has occured
> in interrupt context, then calling sleep() in the oops path will only cause
> a panic, and that it would be really better for it not to be in the path at
> all.
>
> This patch removes the ssleep() call and reworks the console message
> accordinly. I have a slght concern that the resulting console message is
> too long, feedback welcome.
Keeping the delay might be actually useful so that you can see the panic
before system reboots when reboot on panic is enabled. I would just use a loop
of mdelays(1) with touch_nmi_watchdog/touch_softirq_watchdog()s
inbetween.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: Horms <horms@verge.net.au>
Cc: Andrew Morton <akpm@osdl.org>, Chris Zankel <chris@zankel.net>,
Tony Luck <tony.luck@intel.com>,
linux-ia64@vger.kernel.org, discuss@x86-64.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
Russell King <rmk@arm.linux.org.uk>
Subject: Re: [PATCH] panic_on_oops: remove ssleep()
Date: Tue, 18 Jul 2006 00:27:51 +0200 [thread overview]
Message-ID: <200607180027.51986.ak@suse.de> (raw)
In-Reply-To: <31687.FP.7244@verge.net.au>
On Monday 17 July 2006 18:17, Horms wrote:
> This patch is part of an effort to unify the panic_on_oops behaviour
> across all architectures that implement it.
>
> It was pointed out to me by Andi Kleen that if an oops has occured
> in interrupt context, then calling sleep() in the oops path will only cause
> a panic, and that it would be really better for it not to be in the path at
> all.
>
> This patch removes the ssleep() call and reworks the console message
> accordinly. I have a slght concern that the resulting console message is
> too long, feedback welcome.
Keeping the delay might be actually useful so that you can see the panic
before system reboots when reboot on panic is enabled. I would just use a loop
of mdelays(1) with touch_nmi_watchdog/touch_softirq_watchdog()s
inbetween.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: Horms <horms@verge.net.au>
Cc: Russell King <rmk@arm.linux.org.uk>,
Tony Luck <tony.luck@intel.com>,
Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
Chris Zankel <chris@zankel.net>, Andrew Morton <akpm@osdl.org>,
linux-ia64@vger.kernel.org, linuxppc-dev@ozlabs.org,
discuss@x86-64.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] panic_on_oops: remove ssleep()
Date: Tue, 18 Jul 2006 00:27:51 +0200 [thread overview]
Message-ID: <200607180027.51986.ak@suse.de> (raw)
In-Reply-To: <31687.FP.7244@verge.net.au>
On Monday 17 July 2006 18:17, Horms wrote:
> This patch is part of an effort to unify the panic_on_oops behaviour
> across all architectures that implement it.
>
> It was pointed out to me by Andi Kleen that if an oops has occured
> in interrupt context, then calling sleep() in the oops path will only cause
> a panic, and that it would be really better for it not to be in the path at
> all.
>
> This patch removes the ssleep() call and reworks the console message
> accordinly. I have a slght concern that the resulting console message is
> too long, feedback welcome.
Keeping the delay might be actually useful so that you can see the panic
before system reboots when reboot on panic is enabled. I would just use a loop
of mdelays(1) with touch_nmi_watchdog/touch_softirq_watchdog()s
inbetween.
-Andi
next prev parent reply other threads:[~2006-07-17 22:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-17 16:17 [PATCH] panic_on_oops: remove ssleep() Horms
2006-07-17 16:17 ` Horms
2006-07-17 16:17 ` Horms
2006-07-17 22:27 ` Andi Kleen [this message]
2006-07-17 22:27 ` Andi Kleen
2006-07-17 22:27 ` Andi Kleen
2006-07-17 23:10 ` Horms
2006-07-17 23:10 ` Horms
2006-07-17 23:10 ` Horms
2006-07-18 0:23 ` Andrew Morton
2006-07-18 0:23 ` Andrew Morton
2006-07-18 0:23 ` Andrew Morton
2006-07-18 19:13 ` Horms
2006-07-18 19:13 ` Horms
2006-07-18 19:13 ` Horms
2006-07-18 1:22 ` Chuck Ebbert
2006-07-18 1:22 ` Chuck Ebbert
2006-07-18 1:22 ` Chuck Ebbert
2006-07-18 19:15 ` Horms
2006-07-18 19:15 ` Horms
2006-07-18 19:15 ` Horms
2006-07-20 16:03 ` Paul Mackerras
2006-07-20 16:03 ` Paul Mackerras
2006-07-20 16:03 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607180027.51986.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=chris@zankel.net \
--cc=discuss@x86-64.org \
--cc=horms@verge.net.au \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=rmk@arm.linux.org.uk \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.