From: Dave Jones <davej@redhat.com>
To: Dave Airlie <airlied@linux.ie>
Cc: Hugh Dickins <hugh@veritas.com>, Andrew Morton <akpm@osdl.org>,
Dave Jones <davej@codemonkey.org.uk>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] vm/agp: remove private page protection map
Date: Wed, 26 Jul 2006 19:59:31 -0400 [thread overview]
Message-ID: <20060726235931.GA5687@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0607270023120.23571@skynet.skynet.ie>
On Thu, Jul 27, 2006 at 12:24:27AM +0100, Dave Airlie wrote:
> >
> >I'm happy with the intent of your vm_get_page_prot() patch (and would
> >like to extend it to other places after, minimizing references to the
> >protection_map[]). But there's a few aspects which distress me - the
> >u8 type nowhere else in mm, the requirement that caller mask the arg,
> >agp_convert_mmap_flags still using its own conversion from PROT_ to VM_
> >while there's an inline in mm.h (though why someone thought to optimize
> >and so obscure that version puzzles me!). Would you be happy to insert
> >your Sign-off in the replacement below?
>
> No worries, I think davej can drop my one from his tree as well and take
> this..
Done, and pushed out to agpgart.git
Thanks,
Dave
--
http://www.codemonkey.org.uk
WARNING: multiple messages have this Message-ID (diff)
From: Dave Jones <davej@redhat.com>
To: Dave Airlie <airlied@linux.ie>
Cc: Hugh Dickins <hugh@veritas.com>, Andrew Morton <akpm@osdl.org>,
Dave Jones <davej@codemonkey.org.uk>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] vm/agp: remove private page protection map
Date: Wed, 26 Jul 2006 19:59:31 -0400 [thread overview]
Message-ID: <20060726235931.GA5687@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0607270023120.23571@skynet.skynet.ie>
On Thu, Jul 27, 2006 at 12:24:27AM +0100, Dave Airlie wrote:
> >
> >I'm happy with the intent of your vm_get_page_prot() patch (and would
> >like to extend it to other places after, minimizing references to the
> >protection_map[]). But there's a few aspects which distress me - the
> >u8 type nowhere else in mm, the requirement that caller mask the arg,
> >agp_convert_mmap_flags still using its own conversion from PROT_ to VM_
> >while there's an inline in mm.h (though why someone thought to optimize
> >and so obscure that version puzzles me!). Would you be happy to insert
> >your Sign-off in the replacement below?
>
> No worries, I think davej can drop my one from his tree as well and take
> this..
Done, and pushed out to agpgart.git
Thanks,
Dave
--
http://www.codemonkey.org.uk
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-07-26 23:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-18 18:08 [PATCH] vm/agp: remove private page protection map Dave Airlie
2006-07-18 18:08 ` Dave Airlie
2006-07-18 18:23 ` Dave Jones
2006-07-18 18:23 ` Dave Jones
2006-07-26 20:39 ` Hugh Dickins
2006-07-26 20:39 ` Hugh Dickins
2006-07-26 23:24 ` Dave Airlie
2006-07-26 23:24 ` Dave Airlie
2006-07-26 23:59 ` Dave Jones [this message]
2006-07-26 23:59 ` Dave Jones
2006-07-26 23:59 ` Hugh Dickins
2006-07-26 23:59 ` Hugh Dickins
2006-07-27 0:35 ` Dave Jones
2006-07-27 0:35 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060726235931.GA5687@redhat.com \
--to=davej@redhat.com \
--cc=airlied@linux.ie \
--cc=akpm@osdl.org \
--cc=davej@codemonkey.org.uk \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.