* [PATCH] pciback: fix circular loop in pcistub_match_one
@ 2006-08-01 22:12 Jon Mason
2006-08-02 5:52 ` Muli Ben-Yehuda
0 siblings, 1 reply; 3+ messages in thread
From: Jon Mason @ 2006-08-01 22:12 UTC (permalink / raw)
To: xen-devel; +Cc: Muli Ben-Yehuda (IBM), hap9
The for loop in pcistub_match_one will loop forever if the
dev->bus->self links to itself at the uppermost bridge. Adding a check
to prevent linking back in on itself prevents this.
Thanks,
Jon
Signed-off-by: Jon Mason <jdmason@us.ibm.com>
diff -r d2bf1a7cc131 linux-2.6-xen-sparse/drivers/xen/pciback/pci_stub.c
--- a/linux-2.6-xen-sparse/drivers/xen/pciback/pci_stub.c Sat Jul 29 14:05:59 2006 +0100
+++ b/linux-2.6-xen-sparse/drivers/xen/pciback/pci_stub.c Tue Aug 1 10:45:51 2006 -0500
@@ -232,6 +232,9 @@ static int __devinit pcistub_match_one(s
&& dev->bus->number == pdev_id->bus
&& dev->devfn == pdev_id->devfn)
return 1;
+
+ if (dev == dev->bus->self)
+ break;
}
return 0;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pciback: fix circular loop in pcistub_match_one
2006-08-01 22:12 [PATCH] pciback: fix circular loop in pcistub_match_one Jon Mason
@ 2006-08-02 5:52 ` Muli Ben-Yehuda
2006-08-02 15:41 ` Jon Mason
0 siblings, 1 reply; 3+ messages in thread
From: Muli Ben-Yehuda @ 2006-08-02 5:52 UTC (permalink / raw)
To: Jon Mason; +Cc: xen-devel, hap9
On Tue, Aug 01, 2006 at 05:12:07PM -0500, Jon Mason wrote:
> The for loop in pcistub_match_one will loop forever if the
> dev->bus->self links to itself at the uppermost bridge. Adding a check
> to prevent linking back in on itself prevents this.
Also, please apply & push to our xenlinux tree (or I'll do it if you prefer)
Cheers,
Muli
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pciback: fix circular loop in pcistub_match_one
2006-08-02 5:52 ` Muli Ben-Yehuda
@ 2006-08-02 15:41 ` Jon Mason
0 siblings, 0 replies; 3+ messages in thread
From: Jon Mason @ 2006-08-02 15:41 UTC (permalink / raw)
To: Muli Ben-Yehuda; +Cc: xen-devel, hap9
On Wed, Aug 02, 2006 at 08:52:00AM +0300, Muli Ben-Yehuda wrote:
> On Tue, Aug 01, 2006 at 05:12:07PM -0500, Jon Mason wrote:
> > The for loop in pcistub_match_one will loop forever if the
> > dev->bus->self links to itself at the uppermost bridge. Adding a check
> > to prevent linking back in on itself prevents this.
>
> Also, please apply & push to our xenlinux tree (or I'll do it if you prefer)
Will do.
Thanks,
Jon
>
> Cheers,
> Muli
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-08-02 15:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-01 22:12 [PATCH] pciback: fix circular loop in pcistub_match_one Jon Mason
2006-08-02 5:52 ` Muli Ben-Yehuda
2006-08-02 15:41 ` Jon Mason
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.