From: Phil Oester <kernel@linuxace.com>
To: netfilter-devel@lists.netfilter.org
Subject: [PATCH] string match negation fix
Date: Thu, 3 Aug 2006 18:17:40 -0700 [thread overview]
Message-ID: <20060804011740.GA1177@linuxace.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 158 bytes --]
The xt_string match is broken with ! negation.
This resolves a portion of netfilter bugzilla #497.
Phil
Signed-off-by: Phil Oester <kernel@linuxace.com>
[-- Attachment #2: patch-string_negate --]
[-- Type: text/plain, Size: 432 bytes --]
--- linux-dellfw/net/netfilter/xt_string.c 2006-07-15 15:00:43.000000000 -0400
+++ linux-po/net/netfilter/xt_string.c 2006-08-03 21:06:13.000000000 -0400
@@ -37,7 +37,7 @@
return (skb_find_text((struct sk_buff *)skb, conf->from_offset,
conf->to_offset, conf->config, &state)
- != UINT_MAX) && !conf->invert;
+ != UINT_MAX) ^ conf->invert;
}
#define STRING_TEXT_PRIV(m) ((struct xt_string_info *) m)
next reply other threads:[~2006-08-04 1:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-04 1:17 Phil Oester [this message]
2006-08-08 9:09 ` [PATCH] string match negation fix Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060804011740.GA1177@linuxace.com \
--to=kernel@linuxace.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.