All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] string match negation fix
@ 2006-08-04  1:17 Phil Oester
  2006-08-08  9:09 ` Patrick McHardy
  0 siblings, 1 reply; 2+ messages in thread
From: Phil Oester @ 2006-08-04  1:17 UTC (permalink / raw)
  To: netfilter-devel

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

The xt_string match is broken with ! negation.

This resolves a portion of netfilter bugzilla #497.

Phil

Signed-off-by: Phil Oester <kernel@linuxace.com>



[-- Attachment #2: patch-string_negate --]
[-- Type: text/plain, Size: 432 bytes --]

--- linux-dellfw/net/netfilter/xt_string.c	2006-07-15 15:00:43.000000000 -0400
+++ linux-po/net/netfilter/xt_string.c	2006-08-03 21:06:13.000000000 -0400
@@ -37,7 +37,7 @@
 
 	return (skb_find_text((struct sk_buff *)skb, conf->from_offset, 
 			     conf->to_offset, conf->config, &state) 
-			     != UINT_MAX) && !conf->invert;
+			     != UINT_MAX) ^ conf->invert;
 }
 
 #define STRING_TEXT_PRIV(m) ((struct xt_string_info *) m)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-08-08  9:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-04  1:17 [PATCH] string match negation fix Phil Oester
2006-08-08  9:09 ` Patrick McHardy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.