Re: [PATCH] Rate-limit the RTC 'missed interrupts' warning.

Re: [PATCH] Rate-limit the RTC 'missed interrupts' warning.

[Andrew Morton]

On Sat, 5 Aug 2006 01:53:08 +0200
Matthias Urlichs <smurf@smurf.noris.de> wrote:

> Cc: recipient list not shown: ;

I'm assuming there was supposed to be a mailing list there.

> Subject: [PATCH] Rate-limit the RTC 'missed interrupts' warning.
> Date: Sat, 5 Aug 2006 01:53:08 +0200
> 
> Signed-Off-By: Matthias Urlichs <smurf@smurf.noris.de>
> ---
>  drivers/char/rtc.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/rtc.c b/drivers/char/rtc.c
> index 7cac6d0..fbd214f 100644
> --- a/drivers/char/rtc.c
> +++ b/drivers/char/rtc.c
> @@ -1131,7 +1131,8 @@ static void rtc_dropped_irq(unsigned lon
>  
>  	spin_unlock_irq(&rtc_lock);
>  
> -	printk(KERN_WARNING "rtc: lost some interrupts at %ldHz.\n", freq);
> +	if(printk_ratelimit())
> +		printk(KERN_WARNING "rtc: lost some interrupts at %ldHz.\n", freq);
>  
>  	/* Now we have new data */
>  	wake_up_interruptible(&rtc_wait);

What is causing your machine to lose so many RTC interrupts?

Re: [PATCH] Rate-limit the RTC 'missed interrupts' warning.

[Matthias Urlichs]

Hi,

Andrew Morton:
> > Cc: recipient list not shown: ;
> 
> I'm assuming there was supposed to be a mailing list there.
> 
No, just mutt and/or exim being stupid.
> 
> What is causing your machine to lose so many RTC interrupts?

*One* was probably initializing the Zaptel card(s).

I don't know; the stuff scrolled off the screen way too fast.
(Could that printk itself provoke the condition?)

Aug  4 22:29:22 smurf kernel: rtc: lost some interrupts at 1024Hz.
Aug  4 22:29:53 smurf last message repeated 1526 times
Aug  4 22:30:54 smurf last message repeated 3049 times
Aug  4 22:31:54 smurf last message repeated 3002 times

After patching and rebooting, I haven't seen the message again yet.

-- 
Matthias Urlichs   |   {M:U} IT Design @ m-u-it.de   |  smurf@smurf.noris.de
Disclaimer: The quote was selected randomly. Really. | http://smurf.noris.de
 - -
"Our bodies are always exposed to Satan. The maladies
 I suffer are not natural, but Devil's spells."
               [Martin Luther]