* [lm-sensors] [PATCH 5/5] it87: Cleanup set_fan_div
@ 2006-08-08 14:09 Jean Delvare
0 siblings, 0 replies; only message in thread
From: Jean Delvare @ 2006-08-08 14:09 UTC (permalink / raw)
To: lm-sensors
it87: Cleanup set_fan_div
We only change one fan clock divider at a time, so there is only one
fan min which needs to be saved and restored.
Signed-off-by: Jean Delvare <khali at linux-fr.org>
---
drivers/hwmon/it87.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
--- linux-2.6.18-rc4.orig/drivers/hwmon/it87.c 2006-08-08 14:00:49.000000000 +0200
+++ linux-2.6.18-rc4/drivers/hwmon/it87.c 2006-08-08 14:12:03.000000000 +0200
@@ -579,14 +579,14 @@
struct i2c_client *client = to_i2c_client(dev);
struct it87_data *data = i2c_get_clientdata(client);
unsigned long val = simple_strtoul(buf, NULL, 10);
- int i, min[3];
+ int min;
u8 old;
mutex_lock(&data->update_lock);
old = it87_read_value(client, IT87_REG_FAN_DIV);
- for (i = 0; i < 3; i++)
- min[i] = FAN_FROM_REG(data->fan_min[i], DIV_FROM_REG(data->fan_div[i]));
+ /* Save fan min limit */
+ min = FAN_FROM_REG(data->fan_min[nr], DIV_FROM_REG(data->fan_div[nr]));
switch (nr) {
case 0:
@@ -606,10 +606,10 @@
val |= 0x1 << 6;
it87_write_value(client, IT87_REG_FAN_DIV, val);
- for (i = 0; i < 3; i++) {
- data->fan_min[i]úN_TO_REG(min[i], DIV_FROM_REG(data->fan_div[i]));
- it87_write_value(client, IT87_REG_FAN_MIN(i), data->fan_min[i]);
- }
+ /* Restore fan min limit */
+ data->fan_min[nr] = FAN_TO_REG(min, DIV_FROM_REG(data->fan_div[nr]));
+ it87_write_value(client, IT87_REG_FAN_MIN(nr), data->fan_min[nr]);
+
mutex_unlock(&data->update_lock);
return count;
}
--
Jean Delvare
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-08-08 14:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-08 14:09 [lm-sensors] [PATCH 5/5] it87: Cleanup set_fan_div Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.