From: John Levon <levon@movementarian.org>
To: Jan Beulich <jbeulich@novell.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] shared_info size and padding fixes
Date: Thu, 10 Aug 2006 13:13:48 +0100 [thread overview]
Message-ID: <20060810121348.GA24928@totally.trollied.org> (raw)
In-Reply-To: <44DB0B5D.76E4.0078.0@novell.com>
On Thu, Aug 10, 2006 at 10:33:01AM +0200, Jan Beulich wrote:
> >sizeof(shared_info_t) can change even in compatible hypervisor
> versions.
> >Add a clear warning about this, and fix the few places relying on it.
> >In addition, add some padding to arch_shared_info, to allow future
> >additions to the structure without breaking known offsets of members
> >following it in the shared info.
>
> Shouldn't you also bump the ABI version with these compatibility
> breaking
> changes to the shared info structure?
No, see the previous discussion with Keir - changing the size of the
shared info structure is apparently not part of the ABI (hence the
reason for the patch and the explanation above!)
Personally this seems unusual at best to me, but that's the way it is,
and furthermore has already happened with "nmi_reason".
john
next prev parent reply other threads:[~2006-08-10 12:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 21:05 [PATCH] shared_info size and padding fixes John Levon
2006-08-10 8:03 ` Tristan Gingold
2006-08-10 8:31 ` Jan Beulich
2006-08-10 8:42 ` Tristan Gingold
2006-08-10 8:33 ` Jan Beulich
2006-08-10 12:13 ` John Levon [this message]
2006-08-10 13:29 ` Keir Fraser
2006-08-10 13:34 ` John Levon
2006-08-11 13:30 ` John Levon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060810121348.GA24928@totally.trollied.org \
--to=levon@movementarian.org \
--cc=jbeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.