All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: Tristan Gingold <Tristan.Gingold@bull.net>,
	xen-devel@lists.xensource.com,
	John Levon <levon@movementarian.org>
Subject: Re: [PATCH] shared_info size and padding fixes
Date: Thu, 10 Aug 2006 10:31:41 +0200	[thread overview]
Message-ID: <44DB0B0D.76E4.0078.0@novell.com> (raw)
In-Reply-To: <200608101003.37572.Tristan.Gingold@bull.net>

>>  	DEFINE(IA64_SWITCH_STACK_SIZE, sizeof (struct switch_stack));
>>  	DEFINE(IA64_CPU_SIZE, sizeof (struct cpuinfo_ia64));
>>  	DEFINE(UNW_FRAME_INFO_SIZE, sizeof (struct unw_frame_info));
>> -	DEFINE(SHARED_INFO_SIZE, sizeof (struct shared_info));
>>
>>  	BLANK();
>>  	DEFINE(IA64_MCA_CPU_INIT_STACK_OFFSET, offsetof (struct
ia64_mca_cpu,
>
>Please, do not remove this define.  It is used to check the struct is
not 
>bigger than a page!

Checking this should be done with BUILD_BUG_ON() in a .c file, and
hence
not require an entry in asm-offsets.c.

Jan

  reply	other threads:[~2006-08-10  8:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-09 21:05 [PATCH] shared_info size and padding fixes John Levon
2006-08-10  8:03 ` Tristan Gingold
2006-08-10  8:31   ` Jan Beulich [this message]
2006-08-10  8:42     ` Tristan Gingold
2006-08-10  8:33 ` Jan Beulich
2006-08-10 12:13   ` John Levon
2006-08-10 13:29     ` Keir Fraser
2006-08-10 13:34       ` John Levon
2006-08-11 13:30       ` John Levon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44DB0B0D.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=Tristan.Gingold@bull.net \
    --cc=levon@movementarian.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.