From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] Convert DPRINTK to pr_debug in
Date: Mon, 14 Aug 2006 23:59:34 +0000 [thread overview]
Message-ID: <20060814235934.GK4919@us.ibm.com> (raw)
In-Reply-To: <44B44D3A.8010101@gmail.com>
On 14.08.2006 [18:16:08 -0500], Matthew Martin wrote:
> Hello,
> This converts a DPRINTK macro in drivers/parport/daisy.c to pr_debug.
>
> Signed-Off-By: Matthew Martin <lihnucks@gmail.com>
>
> ---
>
> --- vanilla-linux-2.6.18-rc4/drivers/parport/daisy.c 2006-08-09 19:55:17.000000000 -0500
> +++ linux-2.6.18-rc4/drivers/parport/daisy.c 2006-08-14 17:22:38.000000000 -0500
> @@ -23,17 +23,12 @@
> #include <linux/parport.h>
> #include <linux/delay.h>
> #include <linux/sched.h>
> +#include <linux/kernel.h>
>
> #include <asm/current.h>
> #include <asm/uaccess.h>
>
> -#undef DEBUG
>
> -#ifdef DEBUG
> -#define DPRINTK(stuff...) printk (stuff)
> -#else
> -#define DPRINTK(stuff...)
> -#endif
>
> static struct daisydev {
> struct daisydev *next;
> @@ -322,8 +317,7 @@ static int cpp_daisy (struct parport *po
> | PARPORT_STATUS_PAPEROUT
> | PARPORT_STATUS_SELECT
> | PARPORT_STATUS_ERROR)) {
> - DPRINTK (KERN_DEBUG "%s: cpp_daisy: aa5500ff(%02x)\n",
> - port->name, s);
> + pr_debug ("%s: cpp_daisy: aa5500ff(%02x)\n", port->name, s);
Care to stack a patch on top or before this, to not put a space before
the ( in every function call?
Thanks,
Nish
--
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-08-14 23:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-12 1:15 [KJ] [PATCH] Convert DPRINTK to pr_debug in drivers/scsi/ahci.c Matthew Martin
2006-07-12 12:05 ` Matthew Martin
2006-07-12 13:00 ` Domen Puncer
2006-07-12 14:20 ` [KJ] [PATCH] Convert DPRINTK to pr_debug in Matthew Martin
2006-07-12 14:58 ` [KJ] [PATCH] Convert DPRINTK to pr_debug in drivers/scsi/ahci.c Randy.Dunlap
2006-08-14 23:16 ` [KJ] [PATCH] Convert DPRINTK to pr_debug in drivers/parport/daisy.c Matthew Martin
2006-08-14 23:59 ` Nishanth Aravamudan [this message]
2006-08-15 3:15 ` [KJ] [PATCH] Convert DPRINTK to pr_debug in Matthew Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060814235934.GK4919@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.