From: Matthew Martin <lihnucks@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH] Convert DPRINTK to pr_debug in
Date: Wed, 12 Jul 2006 14:20:04 +0000 [thread overview]
Message-ID: <44B50514.7040102@gmail.com> (raw)
In-Reply-To: <44B44D3A.8010101@gmail.com>
Hello,
This converts DPRINTK to pr_debug in drivers/video/i810/i810-i2c.c
I was wondering if I need to add a //#define DEBUG /* remove this for debugging info */ line.
I was searching lkml.org and I saw some of these kind of patches had a line like that.
Signed-off-by: Matthew Martin <lihnucks@gmail.com>
---
--- vanilla-linux-2.6.18-rc1/drivers/video/i810/i810-i2c.c 2006-07-11 15:56:03.000000000 -0500
+++ linux-2.6.18-rc1/drivers/video/i810/i810-i2c.c 2006-07-12 08:37:11.000000000 -0500
@@ -32,13 +32,6 @@
#define SDA_VAL_OUT 0x0800
#define SDA_VAL_IN 0x1000
-#define DEBUG /* define this for verbose EDID parsing output */
-
-#ifdef DEBUG
-#define DPRINTK(fmt, args...) printk(fmt,## args)
-#else
-#define DPRINTK(fmt, args...)
-#endif
static void i810i2c_setscl(void *data, int state)
{
@@ -169,17 +162,17 @@ static u8 *i810_do_probe_i2c_edid(struct
buf = kmalloc(EDID_LENGTH, GFP_KERNEL);
if (!buf) {
- DPRINTK("i810-i2c: Failed to allocate memory\n");
+ pr_debug("i810-i2c: Failed to allocate memory\n");
return NULL;
}
msgs[1].buf = buf;
if (i2c_transfer(&chan->adapter, msgs, 2) = 2) {
- DPRINTK("i810-i2c: I2C Transfer successful\n");
+ pr_debug("i810-i2c: I2C Transfer successful\n");
return buf;
}
- DPRINTK("i810-i2c: Unable to read EDID block.\n");
+ pr_debug("i810-i2c: Unable to read EDID block.\n");
kfree(buf);
return NULL;
}
@@ -190,7 +183,7 @@ int i810_probe_i2c_connector(struct fb_i
u8 *edid = NULL;
int i;
- DPRINTK("i810-i2c: Probe DDC%i Bus\n", conn+1);
+ pr_debug("i810-i2c: Probe DDC%i Bus\n", conn+1);
if (conn < par->ddc_num) {
for (i = 0; i < 3; i++) {
/* Do the real work */
@@ -202,7 +195,7 @@ int i810_probe_i2c_connector(struct fb_i
const u8 *e = fb_firmware_edid(info->device);
if (e != NULL) {
- DPRINTK("i810-i2c: Getting EDID from BIOS\n");
+ pr_debug("i810-i2c: Getting EDID from BIOS\n");
edid = kmalloc(EDID_LENGTH, GFP_KERNEL);
if (edid)
memcpy(edid, e, EDID_LENGTH);
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-07-12 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-12 1:15 [KJ] [PATCH] Convert DPRINTK to pr_debug in drivers/scsi/ahci.c Matthew Martin
2006-07-12 12:05 ` Matthew Martin
2006-07-12 13:00 ` Domen Puncer
2006-07-12 14:20 ` Matthew Martin [this message]
2006-07-12 14:58 ` Randy.Dunlap
2006-08-14 23:16 ` [KJ] [PATCH] Convert DPRINTK to pr_debug in drivers/parport/daisy.c Matthew Martin
2006-08-14 23:59 ` [KJ] [PATCH] Convert DPRINTK to pr_debug in Nishanth Aravamudan
2006-08-15 3:15 ` Matthew Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44B50514.7040102@gmail.com \
--to=lihnucks@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.