[patch 14/14] acpi: memory hotplug: remove useless message at boot time

[patch 14/14] acpi: memory hotplug: remove useless message at boot time

[akpm]

From: Yasunori Goto <y-goto@jp.fujitsu.com>

This is to remove noisy useless message at boot.  The message is a ton of
"ACPI Exception (acpi_memory-0492): AE_ERROR, handle is no memory device"

In my emulation, number of memory devices are not so many (only 6), but,
this messages are displayed 114 times.

It is showed by acpi_memory_register_notify_handler() which is called by
acpi_walk_namespace().

acpi_walk_namespace() parses all of ACPI's namespace and execute
acpi_memory_register_notify_handler().  So, it is called for all of the
device which is defined in namespace.  If the parsing device is not memory,
acpi_memhotplug ignores it due to "no match" and will parse next device. 
This is normal route.

But this message says it is exception. It is meaningless.

Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: "Brown, Len" <len.brown@intel.com>
Cc: "Yu, Luming" <luming.yu@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 drivers/acpi/acpi_memhotplug.c |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff -puN drivers/acpi/acpi_memhotplug.c~acpi-memory-hotplug-remove-useless-message-at-boot-time drivers/acpi/acpi_memhotplug.c
--- a/drivers/acpi/acpi_memhotplug.c~acpi-memory-hotplug-remove-useless-message-at-boot-time
+++ a/drivers/acpi/acpi_memhotplug.c
@@ -484,10 +484,8 @@ acpi_memory_register_notify_handler(acpi
 
 
 	status = is_memory_device(handle);
-	if (ACPI_FAILURE(status)){
-		ACPI_EXCEPTION((AE_INFO, status, "handle is no memory device"));
+	if (ACPI_FAILURE(status))
 		return AE_OK;	/* continue */
-	}
 
 	status = acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY,
 					     acpi_memory_device_notify, NULL);
@@ -503,10 +501,8 @@ acpi_memory_deregister_notify_handler(ac
 
 
 	status = is_memory_device(handle);
-	if (ACPI_FAILURE(status)){
-		ACPI_EXCEPTION((AE_INFO, status, "handle is no memory device"));
+	if (ACPI_FAILURE(status))
 		return AE_OK;	/* continue */
-	}
 
 	status = acpi_remove_notify_handler(handle,
 					    ACPI_SYSTEM_NOTIFY,
_

Re: [patch 14/14] acpi: memory hotplug: remove useless message at boot time

[Len Brown]

Applied.

thanks,
-Len

On Tuesday 15 August 2006 01:37, akpm@osdl.org wrote:
> From: Yasunori Goto <y-goto@jp.fujitsu.com>
> 
> This is to remove noisy useless message at boot.  The message is a ton of
> "ACPI Exception (acpi_memory-0492): AE_ERROR, handle is no memory device"
> 
> In my emulation, number of memory devices are not so many (only 6), but,
> this messages are displayed 114 times.
> 
> It is showed by acpi_memory_register_notify_handler() which is called by
> acpi_walk_namespace().
> 
> acpi_walk_namespace() parses all of ACPI's namespace and execute
> acpi_memory_register_notify_handler().  So, it is called for all of the
> device which is defined in namespace.  If the parsing device is not memory,
> acpi_memhotplug ignores it due to "no match" and will parse next device. 
> This is normal route.
> 
> But this message says it is exception. It is meaningless.
> 
> Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
> Cc: "Brown, Len" <len.brown@intel.com>
> Cc: "Yu, Luming" <luming.yu@intel.com>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
> 
>  drivers/acpi/acpi_memhotplug.c |    8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff -puN drivers/acpi/acpi_memhotplug.c~acpi-memory-hotplug-remove-useless-message-at-boot-time drivers/acpi/acpi_memhotplug.c
> --- a/drivers/acpi/acpi_memhotplug.c~acpi-memory-hotplug-remove-useless-message-at-boot-time
> +++ a/drivers/acpi/acpi_memhotplug.c
> @@ -484,10 +484,8 @@ acpi_memory_register_notify_handler(acpi
>  
>  
>  	status = is_memory_device(handle);
> -	if (ACPI_FAILURE(status)){
> -		ACPI_EXCEPTION((AE_INFO, status, "handle is no memory device"));
> +	if (ACPI_FAILURE(status))
>  		return AE_OK;	/* continue */
> -	}
>  
>  	status = acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY,
>  					     acpi_memory_device_notify, NULL);
> @@ -503,10 +501,8 @@ acpi_memory_deregister_notify_handler(ac
>  
>  
>  	status = is_memory_device(handle);
> -	if (ACPI_FAILURE(status)){
> -		ACPI_EXCEPTION((AE_INFO, status, "handle is no memory device"));
> +	if (ACPI_FAILURE(status))
>  		return AE_OK;	/* continue */
> -	}
>  
>  	status = acpi_remove_notify_handler(handle,
>  					    ACPI_SYSTEM_NOTIFY,
> _
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>