From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drop second arg of unregister_chrdev()
Date: Wed, 16 Aug 2006 09:03:19 +0200 [thread overview]
Message-ID: <200608160903.25145.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <20060815195231.17015.qmail@lwn.net>
[-- Attachment #1: Type: text/plain, Size: 691 bytes --]
Jonathan Corbet wrote:
> > * "name" is trivially unused.
> > * Requirement to pass to unregister function anything but cookie you've
> > got from register counterpart is wrong.
>
> Might this, instead, be an opportunity to get rid of the internal
> register_chrdev() and unregister_chrdev() calls in favor of the cdev
> interface? register_chrdev() is a bit of a backward-compatibility hack
> at this point, and cdevs, in theory, are safer since they won't present
> drivers with minor numbers they might not be prepared to handle.
In this case I would suggest to add documentation to this functions first to
get people the chance to actually know how to use them.
Eike
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-08-16 7:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-15 3:35 [PATCH] Drop second arg of unregister_chrdev() Alexey Dobriyan
2006-08-15 3:48 ` Andrew Morton
2006-08-15 4:18 ` Alexey Dobriyan
2006-08-15 19:52 ` Jonathan Corbet
2006-08-16 7:03 ` Rolf Eike Beer [this message]
2006-08-16 15:42 ` Jonathan Corbet
2006-08-17 21:22 ` cdev documentation (was Drop second arg of unregister_chrdev()) Jonathan Corbet
2006-08-18 7:15 ` Rolf Eike Beer
2006-08-18 12:32 ` Dmitry Torokhov
2006-08-18 12:46 ` [TTY] Remove bogus call to cdev_del() Rolf Eike Beer
2006-08-18 13:02 ` cdev documentation (was Drop second arg of unregister_chrdev()) Jonathan Corbet
2006-08-18 13:49 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608160903.25145.eike-kernel@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.