From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
Cc: "Jonathan Corbet" <corbet@lwn.net>,
"Alexey Dobriyan" <adobriyan@gmail.com>,
"Andrew Morton" <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: [TTY] Remove bogus call to cdev_del()
Date: Fri, 18 Aug 2006 14:46:51 +0200 [thread overview]
Message-ID: <200608181446.52076.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <d120d5000608180532j453bf0f3l2ee88b0502c20cfd@mail.gmail.com>
When cdev_add() failed there is no reason to call cdev_del().
Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
---
commit d31aa8d2f27346fe0663bd9675185c649d5d9801
tree 67f30f1547f19eb2bc0961abf5b4e2f35834ed41
parent f6272846a16df0c7acb5c1701c0acdee0b472047
author Rolf Eike Beer <eike-kernel@sf-tec.de> Fri, 18 Aug 2006 14:45:01 +0200
committer Rolf Eike Beer <beer@siso-eb-i34d.silicon-software.de> Fri, 18 Aug 2006 14:45:01 +0200
drivers/char/tty_io.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
index bfdb902..d6e4eaa 100644
--- a/drivers/char/tty_io.c
+++ b/drivers/char/tty_io.c
@@ -3094,7 +3094,6 @@ int tty_register_driver(struct tty_drive
driver->cdev.owner = driver->owner;
error = cdev_add(&driver->cdev, dev, driver->num);
if (error) {
- cdev_del(&driver->cdev);
unregister_chrdev_region(dev, driver->num);
driver->ttys = NULL;
driver->termios = driver->termios_locked = NULL;
next prev parent reply other threads:[~2006-08-18 12:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-15 3:35 [PATCH] Drop second arg of unregister_chrdev() Alexey Dobriyan
2006-08-15 3:48 ` Andrew Morton
2006-08-15 4:18 ` Alexey Dobriyan
2006-08-15 19:52 ` Jonathan Corbet
2006-08-16 7:03 ` Rolf Eike Beer
2006-08-16 15:42 ` Jonathan Corbet
2006-08-17 21:22 ` cdev documentation (was Drop second arg of unregister_chrdev()) Jonathan Corbet
2006-08-18 7:15 ` Rolf Eike Beer
2006-08-18 12:32 ` Dmitry Torokhov
2006-08-18 12:46 ` Rolf Eike Beer [this message]
2006-08-18 13:02 ` Jonathan Corbet
2006-08-18 13:49 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608181446.52076.eike-kernel@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=corbet@lwn.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.