All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johann Lombardi <johann.lombardi@bull.net>
To: Eric Sandeen <esandeen@redhat.com>
Cc: ext2-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [Ext2-devel] [PATCH] fix ext3 mounts at 16T
Date: Wed, 16 Aug 2006 13:45:46 +0200	[thread overview]
Message-ID: <20060816114546.GE2698@chiva> (raw)
In-Reply-To: <44DD00FA.5060600@redhat.com>

>  static int ext3_check_descriptors (struct super_block * sb)
>  {
>  	struct ext3_sb_info *sbi = EXT3_SB(sb);
> -	ext3_fsblk_t block = le32_to_cpu(sbi->s_es->s_first_data_block);
> +	ext3_fsblk_t first_block = le32_to_cpu(sbi->s_es->s_first_data_block);
> +	ext3_fsblk_t last_block;
>  	struct ext3_group_desc * gdp = NULL;
>  	int desc_block = 0;
>  	int i;
> @@ -1141,12 +1142,16 @@ static int ext3_check_descriptors (struc
>  
>  	for (i = 0; i < sbi->s_groups_count; i++)
>  	{
> +		if (i == sbi->s_groups_count - 1)
> +			last_block = sb->s_blocks_count - 1;
> +		else
> +			last = first + (EXT3_BLOCKS_PER_GROUP(sb) - 1);

I think it should be:
last_block = first_block + ...

Johann

  parent reply	other threads:[~2006-08-16 11:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-11 22:13 [PATCH] fix ext3 mounts at 16T Eric Sandeen
2006-08-11 22:29 ` [Ext2-devel] " Mingming Cao
2006-08-18  8:50   ` Andreas Dilger
2006-08-14 19:54 ` [UPDATED PATCH] " Eric Sandeen
2006-08-14 22:58 ` [PATCH] " Andrew Morton
2006-08-14 23:02   ` [Ext2-devel] " Eric Sandeen
2006-08-15 17:28   ` [PATCH] fix ext2 " Eric Sandeen
2006-08-16 11:45 ` Johann Lombardi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-08-18  9:15 [Ext2-devel] [PATCH] fix ext3 " sho
2006-08-18 14:53 ` Eric Sandeen
2006-08-18 17:33 ` Mingming Cao
2006-08-18 17:39   ` Eric Sandeen
2006-08-18 18:53     ` Mingming Cao
2006-08-18 23:18     ` Andreas Dilger
2006-08-18 23:56       ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060816114546.GE2698@chiva \
    --to=johann.lombardi@bull.net \
    --cc=esandeen@redhat.com \
    --cc=ext2-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.