From: Arnd Bergmann <arnd.bergmann@de.ibm.com>
To: linuxppc-dev@ozlabs.org
Cc: Thomas Klein <tklein@de.ibm.com>,
Jan-Bernd Themann <themann@de.ibm.com>,
netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Thomas Klein <osstklei@de.ibm.com>,
Christoph Raisch <raisch@de.ibm.com>,
Marcus Eder <meder@de.ibm.com>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [2.6.19 PATCH 3/7] ehea: queue management
Date: Fri, 18 Aug 2006 15:47:46 +0200 [thread overview]
Message-ID: <200608181547.47081.arnd.bergmann@de.ibm.com> (raw)
In-Reply-To: <44E5BFB7.4000400@de.ibm.com>
On Friday 18 August 2006 15:25, Thomas Klein wrote:
>
> > wow... is this really so large that it warrants a vmalloc()???
>
> Agreed: Replaced with kmalloc()
My understanding from the previous discussion was that it actually
is a multi-page power of two allocation, so the right choice might
be __get_free_pages() instead of kmalloc, but it probably doesn't
make much of a difference.
You should really do some measurements to see what the minimal
queue sizes are that can get you optimal throughput.
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd.bergmann@de.ibm.com>
To: linuxppc-dev@ozlabs.org
Cc: Thomas Klein <osstklei@de.ibm.com>,
Arjan van de Ven <arjan@infradead.org>,
Thomas Klein <tklein@de.ibm.com>,
Jan-Bernd Themann <themann@de.ibm.com>,
netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Christoph Raisch <raisch@de.ibm.com>,
Marcus Eder <meder@de.ibm.com>
Subject: Re: [2.6.19 PATCH 3/7] ehea: queue management
Date: Fri, 18 Aug 2006 15:47:46 +0200 [thread overview]
Message-ID: <200608181547.47081.arnd.bergmann@de.ibm.com> (raw)
In-Reply-To: <44E5BFB7.4000400@de.ibm.com>
On Friday 18 August 2006 15:25, Thomas Klein wrote:
>
> > wow... is this really so large that it warrants a vmalloc()???
>
> Agreed: Replaced with kmalloc()
My understanding from the previous discussion was that it actually
is a multi-page power of two allocation, so the right choice might
be __get_free_pages() instead of kmalloc, but it probably doesn't
make much of a difference.
You should really do some measurements to see what the minimal
queue sizes are that can get you optimal throughput.
Arnd <><
next prev parent reply other threads:[~2006-08-18 13:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-18 11:31 [2.6.19 PATCH 3/7] ehea: queue management Jan-Bernd Themann
2006-08-18 11:31 ` Jan-Bernd Themann
2006-08-18 12:17 ` Arjan van de Ven
2006-08-18 12:17 ` Arjan van de Ven
2006-08-18 13:25 ` Thomas Klein
2006-08-18 13:25 ` Thomas Klein
2006-08-18 13:47 ` Arnd Bergmann [this message]
2006-08-18 13:47 ` Arnd Bergmann
2006-08-18 14:24 ` Christoph Raisch
2006-08-18 14:24 ` Christoph Raisch
2006-08-18 16:16 ` Arnd Bergmann
2006-08-18 16:16 ` Arnd Bergmann
2006-08-18 14:33 ` Jörn Engel
2006-08-18 14:33 ` Jörn Engel
2006-08-18 14:40 ` Jörn Engel
2006-08-18 14:40 ` Jörn Engel
-- strict thread matches above, loose matches on Subject: below --
2006-08-22 12:53 Jan-Bernd Themann
2006-08-22 12:53 ` Jan-Bernd Themann
2006-08-22 14:01 ` Arnd Bergmann
2006-08-22 14:01 ` Arnd Bergmann
2006-08-22 13:51 ` Jan-Bernd Themann
2006-08-22 13:51 ` Jan-Bernd Themann
2006-08-23 8:57 Jan-Bernd Themann
2006-08-23 8:57 ` Jan-Bernd Themann
2006-09-04 10:39 Jan-Bernd Themann
2006-09-04 10:39 ` Jan-Bernd Themann
2006-09-06 13:32 Jan-Bernd Themann
2006-09-06 13:32 ` Jan-Bernd Themann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608181547.47081.arnd.bergmann@de.ibm.com \
--to=arnd.bergmann@de.ibm.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=meder@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=osstklei@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=themann@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.