From: Jeff Dike <jdike@addtoit.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] arch/um/sys-i386/setjmp.S: useless #ifdef _REGPARM's?
Date: Mon, 21 Aug 2006 22:20:12 -0400 [thread overview]
Message-ID: <20060822022012.GA7070@ccure.user-mode-linux.org> (raw)
In-Reply-To: <20060821215641.GQ11651@stusta.de>
On Mon, Aug 21, 2006 at 11:56:41PM +0200, Adrian Bunk wrote:
> arch/um/sys-i386/setjmp.S contains two #ifdef _REGPARM's.
>
> Even if regparm was used in i386 uml (which isn't currently done (why?)),
> I don't see _REGPARM being defined anywhere.
setjmp.S was stolen from klibc, and I'd just as soon leave it alone and
not try to customize it for UML. That file will disappear if/when klibc
is in mainline, and I can just pull it in from usr.
In general, there's no reason that regparam can't be used for UML. However,
in the past (I don't know if it's still a problem) gcc miscompiled regparam
code in the presence of -pg.
As for why it's not, I don't see any occurences of regparam in include/linux
or include/asm-i386 either.
> Is this a bug waiting for happening when regparm will be used on uml or
> do I miss anything?
Probably not.
Jeff
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Dike <jdike@addtoit.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] arch/um/sys-i386/setjmp.S: useless #ifdef _REGPARM's?
Date: Mon, 21 Aug 2006 22:20:12 -0400 [thread overview]
Message-ID: <20060822022012.GA7070@ccure.user-mode-linux.org> (raw)
In-Reply-To: <20060821215641.GQ11651@stusta.de>
On Mon, Aug 21, 2006 at 11:56:41PM +0200, Adrian Bunk wrote:
> arch/um/sys-i386/setjmp.S contains two #ifdef _REGPARM's.
>
> Even if regparm was used in i386 uml (which isn't currently done (why?)),
> I don't see _REGPARM being defined anywhere.
setjmp.S was stolen from klibc, and I'd just as soon leave it alone and
not try to customize it for UML. That file will disappear if/when klibc
is in mainline, and I can just pull it in from usr.
In general, there's no reason that regparam can't be used for UML. However,
in the past (I don't know if it's still a problem) gcc miscompiled regparam
code in the presence of -pg.
As for why it's not, I don't see any occurences of regparam in include/linux
or include/asm-i386 either.
> Is this a bug waiting for happening when regparm will be used on uml or
> do I miss anything?
Probably not.
Jeff
next prev parent reply other threads:[~2006-08-22 2:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-21 21:56 [uml-devel] arch/um/sys-i386/setjmp.S: useless #ifdef _REGPARM's? Adrian Bunk
2006-08-21 21:56 ` Adrian Bunk
2006-08-22 2:20 ` Jeff Dike [this message]
2006-08-22 2:20 ` [uml-devel] " Jeff Dike
2006-08-22 16:07 ` Adrian Bunk
2006-08-22 16:07 ` Adrian Bunk
2006-08-22 17:42 ` Jeff Dike
2006-08-22 17:42 ` Jeff Dike
2006-08-22 19:28 ` Adrian Bunk
2006-08-22 19:28 ` Adrian Bunk
2006-08-26 10:56 ` Blaisorblade
2006-08-26 10:56 ` Blaisorblade
2006-08-28 20:35 ` Jeff Dike
2006-08-28 20:35 ` Jeff Dike
2006-08-29 8:26 ` Paolo Giarrusso
2006-08-29 8:26 ` Paolo Giarrusso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060822022012.GA7070@ccure.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.