From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John Linville <linville@tuxdriver.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] bcm43xx-softmac - set correct value in mac_suspended for ifdown/ifup sequence
Date: Wed, 23 Aug 2006 10:03:23 +0200 [thread overview]
Message-ID: <200608231003.24043.mb@bu3sch.de> (raw)
In-Reply-To: <44EB8019.3080006@lwfinger.net>
On Wednesday 23 August 2006 00:07, Larry Finger wrote:
> John,
>
> Please apply this to wireless-2.6.
>
> Michael - bcm43xx-d80211 probably needs this as well.
>
> Larry
>
> ---------------------------------------------------
>
> When bcm43xx-softmac is given an ifdown/ifup sequence, the value for bcm->mac_suspended ends up
> wrong, which leads to a large number of assert(bcm->mac_suspended>=0) messages. This one-line patch
> fixes this problem.
I think the following is the correct fix for the issue.
It is already in the d80211 branch. (Seems like it got lost somehow).
Can you test this?
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c 2006-08-23 10:00:27.000000000 +0200
+++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c 2006-08-23 10:01:45.000000000 +0200
@@ -3349,6 +3349,8 @@
memset(bcm->dma_reason, 0, sizeof(bcm->dma_reason));
bcm->irq_savedstate = BCM43xx_IRQ_INITIAL;
+ bcm->mac_suspended = 1;
+
/* Noise calculation context */
memset(&bcm->noisecalc, 0, sizeof(bcm->noisecalc));
--
Greetings Michael.
prev parent reply other threads:[~2006-08-23 8:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-22 22:07 [PATCH] bcm43xx-softmac - set correct value in mac_suspended for ifdown/ifup sequence Larry Finger
2006-08-23 8:03 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608231003.24043.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=Larry.Finger@lwfinger.net \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.