All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: John Linville <linville@tuxdriver.com>
Cc: Michael Buesch <mbuesch@freenet.de>, netdev@vger.kernel.org
Subject: [PATCH] bcm43xx-softmac - set correct value in mac_suspended for ifdown/ifup sequence
Date: Tue, 22 Aug 2006 17:07:21 -0500	[thread overview]
Message-ID: <44EB8019.3080006@lwfinger.net> (raw)

John,

Please apply this to wireless-2.6.

Michael - bcm43xx-d80211 probably needs this as well.

Larry

---------------------------------------------------

When bcm43xx-softmac is given an ifdown/ifup sequence, the value for bcm->mac_suspended ends up 
wrong, which leads to a large number of assert(bcm->mac_suspended>=0) messages. This one-line patch 
fixes this problem.

Signed-Off-By: Larry Finger <Larry.Finger@lwfinger.net>

index b095f3c..f532f3c 100644
--- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ b/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -3484,6 +3484,7 @@ int bcm43xx_select_wireless_core(struct
  	bcm43xx_macfilter_clear(bcm, BCM43xx_MACFILTER_ASSOC);
  	bcm43xx_macfilter_set(bcm, BCM43xx_MACFILTER_SELF, (u8 *)(bcm->net_dev->dev_addr));
  	bcm43xx_security_init(bcm);
+	bcm->mac_suspended = 1;
  	ieee80211softmac_start(bcm->net_dev);

  	/* Let's go! Be careful after enabling the IRQs.

             reply	other threads:[~2006-08-23  0:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-22 22:07 Larry Finger [this message]
2006-08-23  8:03 ` [PATCH] bcm43xx-softmac - set correct value in mac_suspended for ifdown/ifup sequence Michael Buesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44EB8019.3080006@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=linville@tuxdriver.com \
    --cc=mbuesch@freenet.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.