From: Christoph Hellwig <hch@infradead.org>
To: Richard Knutsson <ricknu-0@student.ltu.se>
Cc: James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Conversion to generic boolean
Date: Mon, 28 Aug 2006 10:32:02 +0100 [thread overview]
Message-ID: <20060828093202.GC8980@infradead.org> (raw)
In-Reply-To: <44EFBEFA.2010707@student.ltu.se>
On Sat, Aug 26, 2006 at 05:24:42AM +0200, Richard Knutsson wrote:
> Hello
>
> Just would like to ask if you want patches for:
Total NACK to any of this boolean ididocy. I very much hope you didn't
get the impression you actually have a chance to get this merged.
>
> * (Most importent, may introduce bugs if left alone)
> Fixing boolean checking, ex:
> if (bool == FALSE)
> to
> if (!bool)
this one of course makes sense, but please do it without introducing
any boolean type. Getting rid of all the TRUE/FALSE defines and converting
all scsi drivers to classic C integer as boolean semantics would be
very welcome janitorial work.
next prev parent reply other threads:[~2006-08-28 9:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-26 3:24 Conversion to generic boolean Richard Knutsson
2006-08-28 9:32 ` Christoph Hellwig [this message]
2006-08-28 9:45 ` Jesper Juhl
2006-08-29 11:39 ` Christoph Hellwig
2006-08-28 10:58 ` Jan Engelhardt
2006-08-28 11:11 ` Bernd Petrovitsch
2006-08-28 12:17 ` Richard Knutsson
2006-08-28 19:15 ` Nicholas Miell
2006-08-28 20:55 ` Richard Knutsson
2006-08-28 21:19 ` Nicholas Miell
2006-08-28 21:55 ` Richard Knutsson
2006-08-29 11:41 ` Christoph Hellwig
2006-08-29 12:17 ` Jan Engelhardt
2006-08-29 13:26 ` Peter Williams
2006-08-29 13:56 ` Jan Engelhardt
2006-08-29 12:48 ` Alan Cox
2006-08-29 0:18 ` Andrew Morton
2006-08-29 1:15 ` Nick Piggin
2006-08-29 5:58 ` Jan Engelhardt
2006-08-31 3:50 ` Dmitry Torokhov
2006-09-03 12:51 ` Pavel Machek
2006-08-29 7:29 ` Anton Altaparmakov
2006-08-29 11:46 ` Christoph Hellwig
2006-08-29 12:18 ` Anton Altaparmakov
2006-08-29 11:45 ` Christoph Hellwig
2006-08-29 14:10 ` Richard Knutsson
2006-08-29 15:47 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2006-08-29 5:43 linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060828093202.GC8980@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ricknu-0@student.ltu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.