From: Ralf Baechle <ralf@linux-mips.org>
To: linux-ia64@vger.kernel.org, linux-mips@linux-mips.org,
linuxppc-embedded@ozlabs.org, paulkf@microgate.com,
takata@linux-m32r.org, linux-kernel@vger.kernel.org
Subject: Re: [CFT:PATCH] Removing possible wrong asm/serial.h inclusions
Date: Tue, 29 Aug 2006 16:17:48 +0000 [thread overview]
Message-ID: <20060829161748.GF29289@linux-mips.org> (raw)
In-Reply-To: <20060828085244.GA13544@flint.arm.linux.org.uk>
On Mon, Aug 28, 2006 at 09:52:44AM +0100, Russell King wrote:
> asm/serial.h is supposed to contain the definitions for the architecture
> specific 8250 ports for the 8250 driver. It may also define BASE_BAUD,
> but this is the base baud for the architecture specific ports _only_.
>
> Therefore, nothing other than the 8250 driver should be including this
> header file. In order to move towards this goal, here is a patch which
> removes some of the more obvious incorrect includes of the file.
>
> MIPS and PPC has rather a lot of stuff in asm/serial.h, some of it looks
> related to non-8250 ports. Hence, it's not trivial to conclude that
> these includes are indeed unnecessary, so can mips and ppc people please
> test this patch carefully.
The MIPS bits were just unused leftovers from the days when the arch
code did did register serials & consoles. So for the MIPS bits:
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Ralf
WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: linux-ia64@vger.kernel.org, linux-mips@linux-mips.org,
linuxppc-embedded@ozlabs.org, paulkf@microgate.com,
takata@linux-m32r.org, linux-kernel@vger.kernel.org
Subject: Re: [CFT:PATCH] Removing possible wrong asm/serial.h inclusions
Date: Tue, 29 Aug 2006 17:17:48 +0100 [thread overview]
Message-ID: <20060829161748.GF29289@linux-mips.org> (raw)
In-Reply-To: <20060828085244.GA13544@flint.arm.linux.org.uk>
On Mon, Aug 28, 2006 at 09:52:44AM +0100, Russell King wrote:
> asm/serial.h is supposed to contain the definitions for the architecture
> specific 8250 ports for the 8250 driver. It may also define BASE_BAUD,
> but this is the base baud for the architecture specific ports _only_.
>
> Therefore, nothing other than the 8250 driver should be including this
> header file. In order to move towards this goal, here is a patch which
> removes some of the more obvious incorrect includes of the file.
>
> MIPS and PPC has rather a lot of stuff in asm/serial.h, some of it looks
> related to non-8250 ports. Hence, it's not trivial to conclude that
> these includes are indeed unnecessary, so can mips and ppc people please
> test this patch carefully.
The MIPS bits were just unused leftovers from the days when the arch
code did did register serials & consoles. So for the MIPS bits:
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Ralf
next prev parent reply other threads:[~2006-08-29 16:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-28 8:52 [CFT:PATCH] Removing possible wrong asm/serial.h inclusions Russell King
2006-08-28 8:52 ` Russell King
2006-08-28 14:42 ` Paul Fulghum
2006-08-28 16:28 ` Luck, Tony
2006-08-28 16:28 ` Luck, Tony
2006-08-28 16:28 ` Luck, Tony
2006-08-29 16:17 ` Ralf Baechle [this message]
2006-08-29 16:17 ` Ralf Baechle
2006-08-30 9:09 ` David Howells
2006-08-30 9:09 ` David Howells
2006-08-30 9:09 ` David Howells
2006-08-30 13:03 ` Hirokazu Takata
2006-08-30 13:03 ` Hirokazu Takata
-- strict thread matches above, loose matches on Subject: below --
2006-08-28 20:05 Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060829161748.GF29289@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=paulkf@microgate.com \
--cc=takata@linux-m32r.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.