[PATCH] boot failes when strange value is specified for dom0_max_vcpus

[PATCH] boot failes when strange value is specified for dom0_max_vcpus

[MINAI Katsuhito]

Hi,

This patch corrects the following bug. 

The startup of Xen fails when the following values are specified
for boot option dom0_max_vcpus. 

- Value more than number of physical CPU
- Negative value


Signed-off-by: Katsuhito Minai <minai@jp.fujitsu.com>


diff -r f790546ecfda xen/arch/x86/domain_build.c
--- a/xen/arch/x86/domain_build.c	Mon Aug 28 20:22:56 2006 +0100
+++ b/xen/arch/x86/domain_build.c	Tue Aug 29 17:48:30 2006 +0900
@@ -671,6 +671,8 @@ int construct_dom0(struct domain *d,
 
     if ( opt_dom0_max_vcpus == 0 )
         opt_dom0_max_vcpus = num_online_cpus();
+    if ( opt_dom0_max_vcpus > num_online_cpus() )
+        opt_dom0_max_vcpus = num_online_cpus();
     if ( opt_dom0_max_vcpus > MAX_VIRT_CPUS )
         opt_dom0_max_vcpus = MAX_VIRT_CPUS;
     printk("Dom0 has maximum %u VCPUs\n", opt_dom0_max_vcpus);


Best regards,
Minai

Re: [PATCH] boot failes when strange value is specified for dom0_max_vcpus

[MINAI Katsuhito]

Hi,

I think this behavior is a bug.
Could you apply this patch ?
Or please give me comments.

thanks,
Katsuhito Minai


On Thu, 31 Aug 2006 14:05:09 +0900
MINAI Katsuhito <minai@jp.fujitsu.com> wrote:
> Hi,
> 
> This patch corrects the following bug. 
> 
> The startup of Xen fails when the following values are specified
> for boot option dom0_max_vcpus. 
> 
> - Value more than number of physical CPU
> - Negative value
> 
> 
> Signed-off-by: Katsuhito Minai <minai@jp.fujitsu.com>
> 
> 
> diff -r f790546ecfda xen/arch/x86/domain_build.c
> --- a/xen/arch/x86/domain_build.c	Mon Aug 28 20:22:56 2006 +0100
> +++ b/xen/arch/x86/domain_build.c	Tue Aug 29 17:48:30 2006 +0900
> @@ -671,6 +671,8 @@ int construct_dom0(struct domain *d,
>  
>      if ( opt_dom0_max_vcpus == 0 )
>          opt_dom0_max_vcpus = num_online_cpus();
> +    if ( opt_dom0_max_vcpus > num_online_cpus() )
> +        opt_dom0_max_vcpus = num_online_cpus();
>      if ( opt_dom0_max_vcpus > MAX_VIRT_CPUS )
>          opt_dom0_max_vcpus = MAX_VIRT_CPUS;
>      printk("Dom0 has maximum %u VCPUs\n", opt_dom0_max_vcpus);
> 
> 
> Best regards,
> Minai
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

   /  | /  | 富士通(株)プラットフォーム技開本 仮想システム開発統括部
  /   |/   |_*_ __ __  ___ _*_ 藥 袋 克 仁 email:minai@soft.fujitsu.com
 / /|   /| || |/ |/ |_/  |_| | Phone:055-924-6194 Ex:7551-5366
/_/ |__/ |_||_|-|_/|_//_|_/|_| FAX:  055-924-6148 FAX-ex.7551-6571

Re: [PATCH] boot failes when strange value is specified for dom0_max_vcpus

[MINAI Katsuhito]

Hi,

I think this behavior is a bug.
Could you apply this patch ?
Or please give me comments.

thanks,
Katsuhito Minai


On Thu, 31 Aug 2006 14:05:09 +0900
MINAI Katsuhito <minai@jp.fujitsu.com> wrote:
> Hi,
> 
> This patch corrects the following bug. 
> 
> The startup of Xen fails when the following values are specified
> for boot option dom0_max_vcpus. 
> 
> - Value more than number of physical CPU
> - Negative value
> 
> 
> Signed-off-by: Katsuhito Minai <minai@jp.fujitsu.com>
> 
> 
> diff -r f790546ecfda xen/arch/x86/domain_build.c
> --- a/xen/arch/x86/domain_build.c	Mon Aug 28 20:22:56 2006 +0100
> +++ b/xen/arch/x86/domain_build.c	Tue Aug 29 17:48:30 2006 +0900
> @@ -671,6 +671,8 @@ int construct_dom0(struct domain *d,
>  
>      if ( opt_dom0_max_vcpus == 0 )
>          opt_dom0_max_vcpus = num_online_cpus();
> +    if ( opt_dom0_max_vcpus > num_online_cpus() )
> +        opt_dom0_max_vcpus = num_online_cpus();
>      if ( opt_dom0_max_vcpus > MAX_VIRT_CPUS )
>          opt_dom0_max_vcpus = MAX_VIRT_CPUS;
>      printk("Dom0 has maximum %u VCPUs\n", opt_dom0_max_vcpus);
> 
> 
> Best regards,
> Minai
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

   /  | /  | 富士通(株)プラットフォーム技開本 仮想システム開発統括部
  /   |/   |_*_ __ __  ___ _*_ 藥 袋 克 仁 email:minai@soft.fujitsu.com
 / /|   /| || |/ |/ |_/  |_| | Phone:055-924-6194 Ex:7551-5366
/_/ |__/ |_||_|-|_/|_//_|_/|_| FAX:  055-924-6148 FAX-ex.7551-6571