From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH 4/4] gitweb: Correct typo: '==' instead of 'eq' in git_difftree_body
Date: Mon, 4 Sep 2006 18:19:58 +0200 [thread overview]
Message-ID: <200609041819.58737.jnareb@gmail.com> (raw)
In-Reply-To: <200609041810.09838.jnareb@gmail.com>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
This caused that the "commitdiff" version, with "patch" link to anchor
instead of "diff" link to "blobdiff" view was used even in "commit" view.
gitweb/gitweb.perl | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 4240a30..e7d7bd7 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1519,7 +1519,7 @@ sub git_difftree_body {
$cgi->a({-href => href(action=>"blob", hash=>$diff{'to_id'},
hash_base=>$hash, file_name=>$diff{'file'})},
"blob");
- if ($action == "commitdiff") {
+ if ($action eq 'commitdiff') {
# link to patch
$patchno++;
print " | " .
@@ -1540,7 +1540,7 @@ sub git_difftree_body {
hash_base=>$parent, file_name=>$diff{'file'})},
"blob") .
" | ";
- if ($action == "commitdiff") {
+ if ($action eq 'commitdiff') {
# link to patch
$patchno++;
print " | " .
@@ -1586,7 +1586,7 @@ sub git_difftree_body {
hash_base=>$hash, file_name=>$diff{'file'})},
"blob");
if ($diff{'to_id'} ne $diff{'from_id'}) { # modified
- if ($action == "commitdiff") {
+ if ($action eq 'commitdiff') {
# link to patch
$patchno++;
print " | " .
@@ -1628,7 +1628,7 @@ sub git_difftree_body {
hash=>$diff{'to_id'}, file_name=>$diff{'to_file'})},
"blob");
if ($diff{'to_id'} ne $diff{'from_id'}) {
- if ($action == "commitdiff") {
+ if ($action eq 'commitdiff') {
# link to patch
$patchno++;
print " | " .
--
1.4.1.1
next prev parent reply other threads:[~2006-09-04 16:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 16:10 [PATCH 0/4] gitweb: Some improvements Jakub Narebski
2006-09-04 16:13 ` PATCH 1/4] gitweb: Add GIT favicon, assuming image/png type Jakub Narebski
2006-09-04 17:15 ` Linus Torvalds
2006-09-04 18:32 ` [PATCH " Jakub Narebski
2006-09-04 18:34 ` Jakub Narebski
2006-09-04 22:46 ` Junio C Hamano
2006-09-04 23:00 ` Jakub Narebski
2006-09-04 23:17 ` Junio C Hamano
2006-09-04 16:15 ` [PATCH 2/4] gitweb: Change the name of diff to parent link in "commit" view to "diff" Jakub Narebski
2006-09-04 16:17 ` [PATCH 3/4] gitweb: Divide page path into directories -- path's "breadcrumbs" Jakub Narebski
2006-09-04 16:19 ` Jakub Narebski [this message]
2006-09-04 23:22 ` [PATCH 0/4] gitweb: Some improvements Junio C Hamano
2006-09-04 23:53 ` Jakub Narebski
2006-09-05 8:59 ` gitweb testing and benchmarking (was: [PATCH 0/4] gitweb: Some improvements) Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609041819.58737.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.