From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH 1/4] gitweb: Add GIT favicon, assuming image/png type
Date: Tue, 05 Sep 2006 01:00:04 +0200 [thread overview]
Message-ID: <edib58$61k$1@sea.gmane.org> (raw)
In-Reply-To: 7virk3l07a.fsf@assigned-by-dhcp.cox.net
Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>
>> Jakub Narebski wrote:
>>
>>> index 199fbe87384cd3f4686916277dd124cefc751e8a..f3b762de92e579300eba3f53ee26b2a80b4e76c7 100644
>>
>> Hmmm... I do wonder why --binary implies --full-index option.
>
> Patch safety. Yours happened to be a creation patch so it might
> not matter in this particular case, but we would want to be
> reasonably sure there is no ambiguity in the preimage when you
> are doing a modification patch.
Couldn't we do this (show full sha1) only for the binary part of patch?
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-09-04 23:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 16:10 [PATCH 0/4] gitweb: Some improvements Jakub Narebski
2006-09-04 16:13 ` PATCH 1/4] gitweb: Add GIT favicon, assuming image/png type Jakub Narebski
2006-09-04 17:15 ` Linus Torvalds
2006-09-04 18:32 ` [PATCH " Jakub Narebski
2006-09-04 18:34 ` Jakub Narebski
2006-09-04 22:46 ` Junio C Hamano
2006-09-04 23:00 ` Jakub Narebski [this message]
2006-09-04 23:17 ` Junio C Hamano
2006-09-04 16:15 ` [PATCH 2/4] gitweb: Change the name of diff to parent link in "commit" view to "diff" Jakub Narebski
2006-09-04 16:17 ` [PATCH 3/4] gitweb: Divide page path into directories -- path's "breadcrumbs" Jakub Narebski
2006-09-04 16:19 ` [PATCH 4/4] gitweb: Correct typo: '==' instead of 'eq' in git_difftree_body Jakub Narebski
2006-09-04 23:22 ` [PATCH 0/4] gitweb: Some improvements Junio C Hamano
2006-09-04 23:53 ` Jakub Narebski
2006-09-05 8:59 ` gitweb testing and benchmarking (was: [PATCH 0/4] gitweb: Some improvements) Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='edib58$61k$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.