PCRE breakage [libpcre: added new port]

PCRE breakage [libpcre: added new port]

[Jamie Lenehan]

On Fri, Sep 08, 2006 at 02:49:50PM +0200, "MartinDietze commit" wrote:
> libpcre: added new port.

You added libpcre and removed pcre and in the process you've also:

 - Broken 20+ recipes which DEPEND on pcre. These would all need to
   be modified to depend on libpcre now instead.

 - Removed the clearning of PARALLEL_MAKE so libpcre no longer builds
   for anyone doing parallel builds.

 - It looks like you've also removed the fix which was added to stop
   libtool linking against the host libriares when somethings it
   attempts to link in libpcre on x86_64 hosts.

I think the change of name is ok, since it's only a library and the
new naming matches what happens on other platforms but you really
should also fix up all of the above issues.

-- 
 Jamie Lenehan <lenehan@twibble.org>

Re: PCRE breakage [libpcre: added new port]

[Jamie Lenehan]

On Sat, Sep 09, 2006 at 02:43:28PM +1000, Jamie Lenehan wrote:
> On Fri, Sep 08, 2006 at 02:49:50PM +0200, "MartinDietze commit" wrote:
> > libpcre: added new port.
> 
> You added libpcre and removed pcre and in the process you've also:
> 
>  - Broken 20+ recipes which DEPEND on pcre. These would all need to
>    be modified to depend on libpcre now instead.
> 
>  - Removed the clearning of PARALLEL_MAKE so libpcre no longer builds
>    for anyone doing parallel builds.
> 
>  - It looks like you've also removed the fix which was added to stop
>    libtool linking against the host libriares when somethings it
>    attempts to link in libpcre on x86_64 hosts.

And another one:

   - Removed the LICENSE field from the recipe as well.

-- 
 Jamie Lenehan <lenehan@twibble.org>

Re: PCRE breakage [libpcre: added new port]

[pHilipp Zabel]

On 9/9/06, Jamie Lenehan <lenehan@twibble.org> wrote:
> On Sat, Sep 09, 2006 at 02:43:28PM +1000, Jamie Lenehan wrote:
> > On Fri, Sep 08, 2006 at 02:49:50PM +0200, "MartinDietze commit" wrote:
> > > libpcre: added new port.
> >
> > You added libpcre and removed pcre and in the process you've also:
> >
> >  - Broken 20+ recipes which DEPEND on pcre. These would all need to
> >    be modified to depend on libpcre now instead.

I tried to fix this one in 38f8d73bd80424075b07707fb224234553155085.

> >  - Removed the clearning of PARALLEL_MAKE so libpcre no longer builds
> >    for anyone doing parallel builds.
> >
> >  - It looks like you've also removed the fix which was added to stop
> >    libtool linking against the host libriares when somethings it
> >    attempts to link in libpcre on x86_64 hosts.
>
> And another one:
>
>    - Removed the LICENSE field from the recipe as well.
>
> --
>  Jamie Lenehan <lenehan@twibble.org>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [oe-commits] PCRE breakage [libpcre: added new port]

[Michael 'Mickey' Lauer]

(NOTE: Forwarded to Martin Dietze since I'm not sure whether he's
subscribed to the list yet)

Am Samstag, den 09.09.2006, 14:43 +1000 schrieb Jamie Lenehan:
> On Fri, Sep 08, 2006 at 02:49:50PM +0200, "MartinDietze commit" wrote:
> > libpcre: added new port.
> 
> You added libpcre and removed pcre and in the process you've also:
> 
>  - Broken 20+ recipes which DEPEND on pcre. These would all need to
>    be modified to depend on libpcre now instead.
> 
>  - Removed the clearning of PARALLEL_MAKE so libpcre no longer builds
>    for anyone doing parallel builds.
> 
>  - It looks like you've also removed the fix which was added to stop
>    libtool linking against the host libriares when somethings it
>    attempts to link in libpcre on x86_64 hosts.
> - Removed the LICENSE field from the recipe as well.
> 
> I think the change of name is ok, since it's only a library and the
> new naming matches what happens on other platforms but you really
> should also fix up all of the above issues.

Martin, can you please fix these things?

If you don't have already, make sure you subscribe to this list -- we
have made it a policy that all people with commit access also need to be
subscribed here in order to see comments to their commits.

Thanks,

-- 
Regards,

Michael 'Mickey' Lauer | FreeLancer | http://www.Vanille-Media.de

Re: [oe-commits] PCRE breakage [libpcre: added new port]

[Martin Dietze]

On Sat, September 09, 2006, Michael 'Mickey' Lauer wrote:

> > You added libpcre and removed pcre and in the process you've also:
> > 
> >  - Broken 20+ recipes which DEPEND on pcre. These would all need to
> >    be modified to depend on libpcre now instead.

Something made me think there was no such package (pcre). Seems 
like I need to reduce my number of working hours :/ 
Will fix this as first thing on Monday.

Sorry,

Martin

-- 
-------------- Martin Dietze --------------- / -- 4G Systeme GmbH Hamburg ---
-- martin@the-little-red-haired-girl.org -- / ---- dietze@4g-systems.com ----
------------- / http://herbert.the-little-red-haired-girl.org / -------------
=+= 
Old programmers don't die; they just branch to a new address.

Re: [oe-commits] PCRE breakage [libpcre: added new port]

[Jamie Lenehan]

On Sun, Sep 10, 2006 at 10:55:02AM +0200, Martin Dietze wrote:
> On Sat, September 09, 2006, Michael 'Mickey' Lauer wrote:
> 
> > > You added libpcre and removed pcre and in the process you've also:
> > > 
> > >  - Broken 20+ recipes which DEPEND on pcre. These would all need to
> > >    be modified to depend on libpcre now instead.
> 
> Something made me think there was no such package (pcre). Seems 

Ah, that make sense. I could have fixed this all up when you
submitted it, but I could not decide on exactly what you were doing,
so wanted some confirmation on that first.

> like I need to reduce my number of working hours :/ 

I think we all need that ;)

> Will fix this as first thing on Monday.

Others have fixed most of it by now (the missing LICENSE is about all
that needs to be added now). It's probably a good idea to just
compare the old (now deleted) pcre/pcre_4.4.bb with your new
libpcre/libpcre_4.4.bb and make sure everything from the old one is
in there.

Thanks.

-- 
 Jamie Lenehan <lenehan@twibble.org>