From: Matthew Wilcox <matthew@wil.cx>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/2] struct scsi_lun preparation
Date: Mon, 11 Sep 2006 08:42:35 -0600 [thread overview]
Message-ID: <20060911144235.GI29775@parisc-linux.org> (raw)
In-Reply-To: <20060911143458.GA13318@havoc.gtf.org>
On Mon, Sep 11, 2006 at 10:34:58AM -0400, Jeff Garzik wrote:
> @@ -1313,8 +1313,7 @@ EXPORT_SYMBOL(scsi_print_sense);
> void scsi_print_command(struct scsi_cmnd *cmd)
> {
> /* Assume appended output (i.e. not at start of line) */
> - sdev_printk("", cmd->device, "\n");
> - printk(KERN_INFO " command: ");
> + scmd_printk(KERN_INFO, cmd, "command:\n\t");
> scsi_print_cdb(cmd->cmnd, cmd->cmd_len, 0);
Did you not read the comment above the code you're changing? Or are you
changing all callers? If so, you need to remove the comment as well.
next prev parent reply other threads:[~2006-09-11 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-11 14:34 [PATCH 0/2] struct scsi_lun preparation Jeff Garzik
2006-09-11 14:34 ` [PATCH 1/2] " Jeff Garzik
2006-09-11 14:35 ` [PATCH 2/2] " Jeff Garzik
2006-09-11 14:42 ` Matthew Wilcox [this message]
2006-09-11 17:29 ` [PATCH 0/2] " James Bottomley
2006-09-11 19:55 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060911144235.GI29775@parisc-linux.org \
--to=matthew@wil.cx \
--cc=jeff@garzik.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.