Re: [PATCH 0/2] struct scsi_lun preparation

[Jeff Garzik <jeff@garzik.org>]

James Bottomley wrote:
> On Mon, 2006-09-11 at 10:34 -0400, Jeff Garzik wrote:
>> A long-term, low priority project of mine is to increasingly isolate
>> HCIL addressing, making it easier to directly support FC/SAS-style
>> addressing without hacks and HCIL emulation.
> 
> I'm not sure we want to embed an actual struct scsi_lun into the whole
> of the scsi subsystem.  At the moment, given that no-one's actually
> managed to find any device that goes beyond two levels, the current u32
> for lun is perfectly fine.  If we're eventually forced beyond two
> levels, we can consider the transition (although going to u64 does look
> tempting).
> 
> A pretty print for the current u32 would be very useful though for
> transports dealing with non single level luns (or address methods other
> than zero).

A better subject line would have been "HCIL isolation" I suppose.  I 
would like to see increased usage of the accessors already present in 
include/scsi/scsi_device.h, which would ease the transition from 
hardcoded HCIL struct members to a more flexible addressing method.

Though, FWIW, for LUNs I would certainly like to see u64 rather than 
u32.....

	Jeff