All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linux-mm@kvack.org,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@osdl.org>,
	Mike Waychison <mikew@google.com>
Subject: Re: [RFC] page fault retry with NOPAGE_RETRY
Date: Fri, 15 Sep 2006 00:35:29 -0700	[thread overview]
Message-ID: <20060915003529.8a59c542.akpm@osdl.org> (raw)
In-Reply-To: <20060915001151.75f9a71b.akpm@osdl.org>

On Fri, 15 Sep 2006 00:11:51 -0700
Andrew Morton <akpm@osdl.org> wrote:

> b) It could be more efficient.  Most of the time, there's no need to
>    back all the way out of the pagefault handler and rerun the whole thing.
>    Because most of the time, nobody changed anything in the mm_struct.  We
>    _could_ just retake the mmap_sem after the page comes uptodate and, if
>    nothing has changed, proceed.  I see two ways of doing this:
> 
>    - The simple way: look to see if any other processes are sharing
>      this mm_struct.  If not, just do the synchronous read inside mmap_sem.

This assumes that no other heavyweight process will try to modify this
single-threaded process's mm.  I don't _think_ that happens anywhere, does
it?  access_process_vm() is the only case I can think of, and it does
down_read(other process's mmap_sem).


WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@osdl.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linux-mm@kvack.org,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@osdl.org>,
	Mike Waychison <mikew@google.com>
Subject: Re: [RFC] page fault retry with NOPAGE_RETRY
Date: Fri, 15 Sep 2006 00:35:29 -0700	[thread overview]
Message-ID: <20060915003529.8a59c542.akpm@osdl.org> (raw)
In-Reply-To: <20060915001151.75f9a71b.akpm@osdl.org>

On Fri, 15 Sep 2006 00:11:51 -0700
Andrew Morton <akpm@osdl.org> wrote:

> b) It could be more efficient.  Most of the time, there's no need to
>    back all the way out of the pagefault handler and rerun the whole thing.
>    Because most of the time, nobody changed anything in the mm_struct.  We
>    _could_ just retake the mmap_sem after the page comes uptodate and, if
>    nothing has changed, proceed.  I see two ways of doing this:
> 
>    - The simple way: look to see if any other processes are sharing
>      this mm_struct.  If not, just do the synchronous read inside mmap_sem.

This assumes that no other heavyweight process will try to modify this
single-threaded process's mm.  I don't _think_ that happens anywhere, does
it?  access_process_vm() is the only case I can think of, and it does
down_read(other process's mmap_sem).

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2006-09-15  7:35 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-14 22:55 [RFC] page fault retry with NOPAGE_RETRY Benjamin Herrenschmidt
2006-09-14 22:55 ` Benjamin Herrenschmidt
2006-09-15  0:19 ` Linus Torvalds
2006-09-15  0:19   ` Linus Torvalds
2006-09-15  7:11 ` Andrew Morton
2006-09-15  7:11   ` Andrew Morton
2006-09-15  7:35   ` Andrew Morton [this message]
2006-09-15  7:35     ` Andrew Morton
2006-09-15 13:30     ` Hugh Dickins
2006-09-15 13:30       ` Hugh Dickins
2006-09-16  1:03       ` Benjamin Herrenschmidt
2006-09-16  1:03         ` Benjamin Herrenschmidt
2006-09-19 23:35   ` Mike Waychison
2006-09-19 23:50     ` Benjamin Herrenschmidt
2006-09-19 23:50       ` Benjamin Herrenschmidt
2006-09-19 23:59       ` Andrew Morton
2006-09-19 23:59         ` Andrew Morton
2006-09-20  0:06         ` Benjamin Herrenschmidt
2006-09-20  0:06           ` Benjamin Herrenschmidt
2006-09-20  0:05       ` Benjamin Herrenschmidt
2006-09-20  0:05         ` Benjamin Herrenschmidt
2006-09-20  0:21         ` Andrew Morton
2006-09-20  0:21           ` Andrew Morton
2006-09-20  1:57           ` Benjamin Herrenschmidt
2006-09-20  1:57             ` Benjamin Herrenschmidt
2006-09-20  3:05             ` Andrew Morton
2006-09-20  3:05               ` Andrew Morton
2006-09-20  5:04               ` Benjamin Herrenschmidt
2006-09-20  5:04                 ` Benjamin Herrenschmidt
2006-09-20  5:26                 ` Andrew Morton
2006-09-20  5:26                   ` Andrew Morton
2006-09-20  6:54                   ` Benjamin Herrenschmidt
2006-09-20  6:54                     ` Benjamin Herrenschmidt
2006-09-20 17:53                     ` Andrew Morton
2006-09-20 17:53                       ` Andrew Morton
2006-09-21 22:05                       ` Benjamin Herrenschmidt
2006-09-21 22:05                         ` Benjamin Herrenschmidt
2006-09-21 22:41                         ` Andrew Morton
2006-09-21 22:41                           ` Andrew Morton
2006-09-21 23:09                           ` Benjamin Herrenschmidt
2006-09-21 23:09                             ` Benjamin Herrenschmidt
2006-09-23 14:21                       ` Hugh Dickins
2006-09-23 14:21                         ` Hugh Dickins
2006-09-23 19:46                         ` Andrew Morton
2006-09-23 19:46                           ` Andrew Morton
2006-09-23 22:35                           ` Benjamin Herrenschmidt
2006-09-23 22:35                             ` Benjamin Herrenschmidt
2006-09-20  5:06               ` Benjamin Herrenschmidt
2006-09-20  5:06                 ` Benjamin Herrenschmidt
2006-09-20  1:14       ` Mike Waychison
2006-09-20  1:14         ` Mike Waychison
2006-09-20  2:02         ` Benjamin Herrenschmidt
2006-09-20  2:02           ` Benjamin Herrenschmidt
2006-09-15 21:35 ` Arnd Bergmann
2006-09-15 21:35   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060915003529.8a59c542.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mikew@google.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.