All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: Andi Kleen <ak@suse.de>
Cc: "Vladimir B. Savkin" <master@sectorb.msk.ru>,
	Jesper Dangaard Brouer <hawk@diku.dk>,
	Harry Edmon <harry@atmos.washington.edu>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: Network performance degradation from 2.6.11.12 to 2.6.16.20
Date: Tue, 19 Sep 2006 01:03:21 +0400	[thread overview]
Message-ID: <20060918210321.GA4780@ms2.inr.ac.ru> (raw)
In-Reply-To: <200609181850.22851.ak@suse.de>

Hello!

> But that never happens right? 

Right.

Well, not right. It happens. Simply because you get packet
with newer timestamp after previous handler saw this packet
and did some actions. I just do not see any bad consequences.


> And do you have some other prefered way to solve this? Even if the timer
> was fast it would be still good to avoid it in the fast path when DHCPD
> is running.

No. The way, which you suggested, seems to be the best.


1. It even does not disable possibility to record timestamp inside
   driver, which Alan was afraid of. The sequence is:

	if (!skb->tstamp.off_sec)
                net_timestamp(skb);

2. Maybe, netif_rx() should continue to get timestamp in netif_rx().

3. NAPI already introduced almost the same inaccuracy. And it is really
   silly to waste time getting timestamp in netif_receive_skb() a few
   moments before the packet is delivered to a socket.

4. ...but clock source, which takes one of top lines in profiles
   must be repaired yet. :-)

Alexey

  reply	other threads:[~2006-09-18 21:03 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-16 16:01 Network performance degradation from 2.6.11.12 to 2.6.16.20 Harry Edmon
2006-06-17 22:35 ` Andrew Morton
2006-06-17 23:23   ` Harry Edmon
2006-06-17 23:56     ` Andrew Morton
2006-06-18  3:16       ` Stephen Hemminger
2006-06-18 23:23         ` Harry Edmon
2006-06-19 13:54         ` Harry Edmon
2006-06-20  2:11           ` Herbert Xu
2006-06-19 14:47     ` Jesper Dangaard Brouer
2006-06-19 15:24       ` Andi Kleen
2006-06-19 17:34         ` Chris Friesen
2006-06-19 20:39           ` Andi Kleen
2006-06-19 18:24         ` Jesper Dangaard Brouer
2006-06-25 21:51           ` Harry Edmon
2006-06-26  4:20             ` Bill Fink
2006-06-25 22:22         ` Willy Tarreau
2006-06-26  5:23           ` Andi Kleen
2006-07-04 11:41             ` Jesper Dangaard Brouer
2006-07-04 11:54               ` Andi Kleen
2006-07-10 10:55                 ` Jesper Dangaard Brouer
2006-09-16 12:08         ` Vladimir B. Savkin
2006-09-18  8:35           ` Andi Kleen
2006-09-18  9:03             ` Vladimir B. Savkin
2006-09-18  9:58               ` Andi Kleen
2006-09-18 10:29                 ` Vladimir B. Savkin
2006-09-18 11:27                   ` Andi Kleen
2006-09-18 15:38                     ` Alexey Kuznetsov
2006-09-18 15:54                       ` Andi Kleen
2006-09-18 16:28                         ` Alexey Kuznetsov
2006-09-18 16:50                           ` Andi Kleen
2006-09-18 21:03                             ` Alexey Kuznetsov [this message]
2006-09-18 21:22                               ` David Miller
2006-09-18 21:46                                 ` Alexey Kuznetsov
2006-09-19  5:55                                 ` Andi Kleen
2006-09-19 20:31                                 ` Thomas Graf
2006-09-19 20:43                                   ` Andi Kleen
2006-09-19  5:52                               ` Andi Kleen
2006-09-18 21:18                             ` Vladimir B. Savkin
2006-09-18 22:00                               ` Alexey Kuznetsov
2006-09-18 21:57                                 ` David Lang
2006-09-19 19:40                                   ` David Miller
2006-09-19 19:44                                     ` Stephen Hemminger
2006-09-18 22:03                                 ` Vladimir B. Savkin
2006-09-19 19:41                                   ` David Miller
2006-09-19 19:47                                 ` David Miller
2006-09-22 15:35                                   ` Alexey Kuznetsov
2006-09-22 15:43                                     ` Andi Kleen
2006-09-22 16:51                                       ` Rick Jones
2007-03-06 13:25                                         ` Packet timestamps (was: Re: Network performance degradation from 2.6.11.12 to 2.6.16.20) Vladimir B. Savkin
2007-03-06 14:38                                           ` Eric Dumazet
2007-03-06 14:43                                             ` Vladimir B. Savkin
2007-03-06 15:16                                               ` Eric Dumazet
2007-03-06 18:15                                                 ` Vladimir B. Savkin
2006-09-18 21:08                     ` Network performance degradation from 2.6.11.12 to 2.6.16.20 Vladimir B. Savkin
2006-09-18 14:09                 ` David Miller
2006-09-18 14:29                   ` Andi Kleen
2006-09-18 15:19                     ` Alan Cox
2006-09-18 15:19                       ` Andi Kleen
2006-06-19 16:40       ` Harry Edmon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060918210321.GA4780@ms2.inr.ac.ru \
    --to=kuznet@ms2.inr.ac.ru \
    --cc=ak@suse.de \
    --cc=harry@atmos.washington.edu \
    --cc=hawk@diku.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=master@sectorb.msk.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.