From: Eric Dumazet <dada1@cosmosbay.com>
To: "Vladimir B. Savkin" <master@sectorb.msk.ru>
Cc: netdev@vger.kernel.org, Andi Kleen <ak@suse.de>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
David Miller <davem@davemloft.net>,
hawk@diku.dk, harry@atmos.washington.edu,
linux-kernel@vger.kernel.org, Rick Jones <rick.jones2@hp.com>
Subject: Re: Packet timestamps (was: Re: Network performance degradation from 2.6.11.12 to 2.6.16.20)
Date: Tue, 6 Mar 2007 16:16:24 +0100 [thread overview]
Message-ID: <200703061616.24959.dada1@cosmosbay.com> (raw)
In-Reply-To: <20070306144315.GA9036@tentacle.sectorb.msk.ru>
On Tuesday 06 March 2007 15:43, Vladimir B. Savkin wrote:
> On Tue, Mar 06, 2007 at 03:38:44PM +0100, Eric Dumazet wrote:
> > 2) "accurate_timestamps" is misleading.
> > Should be "disable_timestamps"
>
> Not, if default is 1, as in my patch.
Yes I saw this. I should write more words next time :)
Full explanation:
----------------------
If your tunable is named "accurate_timestamps" then a 0 value would mean :
Use a low precision timestamp (based on xtime for example) instead of a full
resolution...
This is not what your patch does (while it could do that, but beware that
net-2.6.22 includes now a ktime_t timestamping)
So :
------
It would be better to name the tunable "disable_timestamps", default 0 of
course....
It would better describe what your patch is actually doing : Even if a tcpdump
is running (so asking for timestamps), it wont have them because the sysctl
disabled them.
Thank you
next prev parent reply other threads:[~2007-03-06 15:16 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-16 16:01 Network performance degradation from 2.6.11.12 to 2.6.16.20 Harry Edmon
2006-06-17 22:35 ` Andrew Morton
2006-06-17 23:23 ` Harry Edmon
2006-06-17 23:56 ` Andrew Morton
2006-06-18 3:16 ` Stephen Hemminger
2006-06-18 23:23 ` Harry Edmon
2006-06-19 13:54 ` Harry Edmon
2006-06-20 2:11 ` Herbert Xu
2006-06-19 14:47 ` Jesper Dangaard Brouer
2006-06-19 15:24 ` Andi Kleen
2006-06-19 17:34 ` Chris Friesen
2006-06-19 20:39 ` Andi Kleen
2006-06-19 18:24 ` Jesper Dangaard Brouer
2006-06-25 21:51 ` Harry Edmon
2006-06-26 4:20 ` Bill Fink
2006-06-25 22:22 ` Willy Tarreau
2006-06-26 5:23 ` Andi Kleen
2006-07-04 11:41 ` Jesper Dangaard Brouer
2006-07-04 11:54 ` Andi Kleen
2006-07-10 10:55 ` Jesper Dangaard Brouer
2006-09-16 12:08 ` Vladimir B. Savkin
2006-09-18 8:35 ` Andi Kleen
2006-09-18 9:03 ` Vladimir B. Savkin
2006-09-18 9:58 ` Andi Kleen
2006-09-18 10:29 ` Vladimir B. Savkin
2006-09-18 11:27 ` Andi Kleen
2006-09-18 15:38 ` Alexey Kuznetsov
2006-09-18 15:54 ` Andi Kleen
2006-09-18 16:28 ` Alexey Kuznetsov
2006-09-18 16:50 ` Andi Kleen
2006-09-18 21:03 ` Alexey Kuznetsov
2006-09-18 21:22 ` David Miller
2006-09-18 21:46 ` Alexey Kuznetsov
2006-09-19 5:55 ` Andi Kleen
2006-09-19 20:31 ` Thomas Graf
2006-09-19 20:43 ` Andi Kleen
2006-09-19 5:52 ` Andi Kleen
2006-09-18 21:18 ` Vladimir B. Savkin
2006-09-18 22:00 ` Alexey Kuznetsov
2006-09-18 21:57 ` David Lang
2006-09-19 19:40 ` David Miller
2006-09-19 19:44 ` Stephen Hemminger
2006-09-18 22:03 ` Vladimir B. Savkin
2006-09-19 19:41 ` David Miller
2006-09-19 19:47 ` David Miller
2006-09-22 15:35 ` Alexey Kuznetsov
2006-09-22 15:43 ` Andi Kleen
2006-09-22 16:51 ` Rick Jones
2007-03-06 13:25 ` Packet timestamps (was: Re: Network performance degradation from 2.6.11.12 to 2.6.16.20) Vladimir B. Savkin
2007-03-06 14:38 ` Eric Dumazet
2007-03-06 14:43 ` Vladimir B. Savkin
2007-03-06 15:16 ` Eric Dumazet [this message]
2007-03-06 18:15 ` Vladimir B. Savkin
2006-09-18 21:08 ` Network performance degradation from 2.6.11.12 to 2.6.16.20 Vladimir B. Savkin
2006-09-18 14:09 ` David Miller
2006-09-18 14:29 ` Andi Kleen
2006-09-18 15:19 ` Alan Cox
2006-09-18 15:19 ` Andi Kleen
2006-06-19 16:40 ` Harry Edmon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703061616.24959.dada1@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=ak@suse.de \
--cc=davem@davemloft.net \
--cc=harry@atmos.washington.edu \
--cc=hawk@diku.dk \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=master@sectorb.msk.ru \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.