From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Mark Ferrell <mferrell@mvista.com>
Subject: Re: [PATCH 4/4] pmc551 pci cleanup
Date: Tue, 19 Sep 2006 08:50:15 +0200 [thread overview]
Message-ID: <200609190850.20778.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <91292449121291221@karneval.cz>
[-- Attachment #1: Type: text/plain, Size: 1901 bytes --]
Am Dienstag, 19. September 2006 00:47 schrieb Jiri Slaby:
> pmc551 pci cleanup
>
> use pci_get_device -- refcounting, release it by pci_dev_put. Use
> pci_resource_start for getting start of regions.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
>
> ---
> commit 6fe18c54c93d38eec34ca0776da60fc355968f6b
> tree 5bf3cf8fe213de770c7c7a1279eafb3937f4c386
> parent 912ff3e53f760cb166988fcd46fc173f8e4c22e7
> author Jiri Slaby <xslaby@anemoi.localdomain> Tue, 19 Sep 2006 00:39:08
> +0200 committer Jiri Slaby <xslaby@anemoi.localdomain> Tue, 19 Sep 2006
> 00:39:08 +0200
You should change your .git/config and add a user section to get the mail
address correct I think.
> drivers/mtd/devices/pmc551.c | 21 +++++++++++++--------
> 1 files changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mtd/devices/pmc551.c b/drivers/mtd/devices/pmc551.c
> index 5f5de9c..d1ba4b9 100644
> --- a/drivers/mtd/devices/pmc551.c
> +++ b/drivers/mtd/devices/pmc551.c
> @@ -563,7 +563,7 @@ #ifdef CONFIG_MTD_PMC551_DEBUG
> size >> 10 : size >> 20,
> (size < 1024) ? 'B' : (size < 1048576) ? 'K' : 'M', size,
> ((dcmd & (0x1 << 3)) == 0) ? "non-" : "",
> - (unsigned long long)((dev->resource[0].start) &
> + (unsigned long long)(pci_resource_start(dev, 0) &
> PCI_BASE_ADDRESS_MEM_MASK));
>
> /*
The last part is unneeded in both versions, when resource[n].start is set the
PCI core already does the masking.
> @@ -755,14 +758,14 @@ static int __init init_pmc551(void)
> "size %dM\n", asize >> 20);
> priv->asize = asize;
> }
> - priv->start = ioremap(((PCI_Device->resource[0].start)
> - & PCI_BASE_ADDRESS_MEM_MASK),
> - priv->asize);
> + priv->start = ioremap(pci_resource_start(PCI_Device, 0) &
> + PCI_BASE_ADDRESS_MEM_MASK, priv->asize);
pci_iomap(PCI_Device, 0, priv->asize);
Eike
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Mark Ferrell <mferrell@mvista.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 4/4] pmc551 pci cleanup
Date: Tue, 19 Sep 2006 08:50:15 +0200 [thread overview]
Message-ID: <200609190850.20778.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <91292449121291221@karneval.cz>
[-- Attachment #1: Type: text/plain, Size: 1901 bytes --]
Am Dienstag, 19. September 2006 00:47 schrieb Jiri Slaby:
> pmc551 pci cleanup
>
> use pci_get_device -- refcounting, release it by pci_dev_put. Use
> pci_resource_start for getting start of regions.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
>
> ---
> commit 6fe18c54c93d38eec34ca0776da60fc355968f6b
> tree 5bf3cf8fe213de770c7c7a1279eafb3937f4c386
> parent 912ff3e53f760cb166988fcd46fc173f8e4c22e7
> author Jiri Slaby <xslaby@anemoi.localdomain> Tue, 19 Sep 2006 00:39:08
> +0200 committer Jiri Slaby <xslaby@anemoi.localdomain> Tue, 19 Sep 2006
> 00:39:08 +0200
You should change your .git/config and add a user section to get the mail
address correct I think.
> drivers/mtd/devices/pmc551.c | 21 +++++++++++++--------
> 1 files changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mtd/devices/pmc551.c b/drivers/mtd/devices/pmc551.c
> index 5f5de9c..d1ba4b9 100644
> --- a/drivers/mtd/devices/pmc551.c
> +++ b/drivers/mtd/devices/pmc551.c
> @@ -563,7 +563,7 @@ #ifdef CONFIG_MTD_PMC551_DEBUG
> size >> 10 : size >> 20,
> (size < 1024) ? 'B' : (size < 1048576) ? 'K' : 'M', size,
> ((dcmd & (0x1 << 3)) == 0) ? "non-" : "",
> - (unsigned long long)((dev->resource[0].start) &
> + (unsigned long long)(pci_resource_start(dev, 0) &
> PCI_BASE_ADDRESS_MEM_MASK));
>
> /*
The last part is unneeded in both versions, when resource[n].start is set the
PCI core already does the masking.
> @@ -755,14 +758,14 @@ static int __init init_pmc551(void)
> "size %dM\n", asize >> 20);
> priv->asize = asize;
> }
> - priv->start = ioremap(((PCI_Device->resource[0].start)
> - & PCI_BASE_ADDRESS_MEM_MASK),
> - priv->asize);
> + priv->start = ioremap(pci_resource_start(PCI_Device, 0) &
> + PCI_BASE_ADDRESS_MEM_MASK, priv->asize);
pci_iomap(PCI_Device, 0, priv->asize);
Eike
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-09-19 6:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-18 22:47 [PATCH 4/4] pmc551 pci cleanup Jiri Slaby
2006-09-18 22:47 ` Jiri Slaby
2006-09-19 6:50 ` Rolf Eike Beer [this message]
2006-09-19 6:50 ` Rolf Eike Beer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609190850.20778.eike-kernel@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=akpm@osdl.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mferrell@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.