* [PATCH] ams: remove usage of input_dev cdev
@ 2006-09-21 0:51 Aristeu Sergio Rozanski Filho
2006-09-21 1:59 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Aristeu Sergio Rozanski Filho @ 2006-09-21 0:51 UTC (permalink / raw)
To: Michael Hanselmann; +Cc: akpm, linux-kernel
This patch removes usage of 'cdev' member of input_dev, not present
on that struct anymore.
Signed-off-by: Aristeu S. Rozanski F. <aris@cathedrallabs.org>
--- mm.orig/drivers/hwmon/ams/ams-mouse.c 2006-09-20 13:57:59.000000000 -0300
+++ mm/drivers/hwmon/ams/ams-mouse.c 2006-09-20 21:01:59.000000000 -0300
@@ -66,7 +66,6 @@
ams_info.idev->name = "Apple Motion Sensor";
ams_info.idev->id.bustype = ams_info.bustype;
ams_info.idev->id.vendor = 0;
- ams_info.idev->cdev.dev = &ams_info.of_dev->dev;
input_set_abs_params(ams_info.idev, ABS_X, -50, 50, 3, 0);
input_set_abs_params(ams_info.idev, ABS_Y, -50, 50, 3, 0);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ams: remove usage of input_dev cdev
2006-09-21 0:51 [PATCH] ams: remove usage of input_dev cdev Aristeu Sergio Rozanski Filho
@ 2006-09-21 1:59 ` Dmitry Torokhov
2006-09-21 2:13 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2006-09-21 1:59 UTC (permalink / raw)
To: Aristeu Sergio Rozanski Filho; +Cc: Michael Hanselmann, akpm, linux-kernel
On Wednesday 20 September 2006 20:51, Aristeu Sergio Rozanski Filho wrote:
> This patch removes usage of 'cdev' member of input_dev, not present
> on that struct anymore.
>
Where did it go?
> Signed-off-by: Aristeu S. Rozanski F. <aris@cathedrallabs.org>
>
> --- mm.orig/drivers/hwmon/ams/ams-mouse.c 2006-09-20 13:57:59.000000000 -0300
> +++ mm/drivers/hwmon/ams/ams-mouse.c 2006-09-20 21:01:59.000000000 -0300
> @@ -66,7 +66,6 @@
> ams_info.idev->name = "Apple Motion Sensor";
> ams_info.idev->id.bustype = ams_info.bustype;
> ams_info.idev->id.vendor = 0;
> - ams_info.idev->cdev.dev = &ams_info.of_dev->dev;
>
> input_set_abs_params(ams_info.idev, ABS_X, -50, 50, 3, 0);
> input_set_abs_params(ams_info.idev, ABS_Y, -50, 50, 3, 0);
>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ams: remove usage of input_dev cdev
2006-09-21 1:59 ` Dmitry Torokhov
@ 2006-09-21 2:13 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2006-09-21 2:13 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Aristeu Sergio Rozanski Filho, Michael Hanselmann, linux-kernel
On Wed, 20 Sep 2006 21:59:53 -0400
Dmitry Torokhov <dtor@insightbb.com> wrote:
> On Wednesday 20 September 2006 20:51, Aristeu Sergio Rozanski Filho wrote:
> > This patch removes usage of 'cdev' member of input_dev, not present
> > on that struct anymore.
> >
>
> Where did it go?
Sigh. That would make a good ./.signature
> > Signed-off-by: Aristeu S. Rozanski F. <aris@cathedrallabs.org>
> >
> > --- mm.orig/drivers/hwmon/ams/ams-mouse.c 2006-09-20 13:57:59.000000000 -0300
> > +++ mm/drivers/hwmon/ams/ams-mouse.c 2006-09-20 21:01:59.000000000 -0300
> > @@ -66,7 +66,6 @@
> > ams_info.idev->name = "Apple Motion Sensor";
> > ams_info.idev->id.bustype = ams_info.bustype;
> > ams_info.idev->id.vendor = 0;
> > - ams_info.idev->cdev.dev = &ams_info.of_dev->dev;
> >
> > input_set_abs_params(ams_info.idev, ABS_X, -50, 50, 3, 0);
> > input_set_abs_params(ams_info.idev, ABS_Y, -50, 50, 3, 0);
> >
I think the right fix is s/cdev.dev/d.parent/g. But Greg has moved all
those patches out of the tree which I'll henceforth be merging into -mm, so
we can stop worrying about it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-09-21 2:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-21 0:51 [PATCH] ams: remove usage of input_dev cdev Aristeu Sergio Rozanski Filho
2006-09-21 1:59 ` Dmitry Torokhov
2006-09-21 2:13 ` Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.