All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] wrong thing iounmapped (qla3xxx)
@ 2006-09-25  1:54 Al Viro
  0 siblings, 0 replies; only message in thread
From: Al Viro @ 2006-09-25  1:54 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Jeff Garzik, linux-kernel

ql3xxx_probe() does ioremap and stores result in
->mem_map_registers.  On failure exit it does iounmap()
of the same thing.  OTOH, ql3xxx_remove() does iounmap()
of ->mmap_virt_base which is (a) never assigned and
(b) never used other than in that iounmap() call.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 drivers/net/qla3xxx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
index c184cd8..1574718 100644
--- a/drivers/net/qla3xxx.c
+++ b/drivers/net/qla3xxx.c
@@ -3508,7 +3508,7 @@ static void __devexit ql3xxx_remove(stru
 		qdev->workqueue = NULL;
 	}
 
-	iounmap(qdev->mmap_virt_base);
+	iounmap(qdev->mem_map_registers);
 	pci_release_regions(pdev);
 	pci_set_drvdata(pdev, NULL);
 	free_netdev(ndev);
-- 
1.4.2.GIT


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2006-09-25  1:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-25  1:54 [PATCH] wrong thing iounmapped (qla3xxx) Al Viro

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.