From: Hashem Masoud <masoudh@batelco.com.bh>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] check return code for request_region() in
Date: Fri, 29 Sep 2006 18:59:39 +0000 [thread overview]
Message-ID: <20060929185939.GA8167@localhost.localdomain> (raw)
In-Reply-To: <20060928103514.GA12240@localhost.localdomain>
> Now, what I *was* talking about was this bit of your patch: "if
> !(request_region"
> That should have been "if (!request_region"
This is a corrected patch compile-tested with allmodconfig and make sound/oss/ .
Signed-off-by: Hashem Masoud <masoudh@batelco.com.bh>
---
gus_wave.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
---
diff -urp linux-2.6.17.13/sound/oss/gus_wave.c linux/sound/oss/gus_wave.c
--- linux-2.6.17.13/sound/oss/gus_wave.c 2006-09-27 19:03:42.000000000 -0300
+++ linux/sound/oss/gus_wave.c 2006-09-28 20:17:41.093694160 -0300
@@ -2938,7 +2938,10 @@ void __init gus_wave_init(struct address
model_num = "3.7";
gus_type = 0x37;
mixer_type = ICS2101;
- request_region(u_MixSelect, 1, "GUS mixer");
+ if (!request_region(u_MixSelect, 1, "GUS mixer")) {
+ printk(KERN_ERR "request_region failed\n");
+ return;
+ }
}
else
{
@@ -3084,7 +3087,10 @@ void __init gus_wave_init(struct address
case ICS2101:
gus_mic_vol = gus_line_vol = gus_pcm_volume = 100;
gus_wave_volume = 90;
- request_region(u_MixSelect, 1, "GUS mixer");
+ if (!request_region(u_MixSelect, 1, "GUS mixer")) {
+ printk(KERN_ERR "request_region failed\n");
+ return;
+ }
hw_config->slots[5] = ics2101_mixer_init();
audio_devs[gus_devnum]->mixer_dev = hw_config->slots[5]; /* Next mixer# */
return;
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2006-09-29 18:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 10:35 [KJ] [PATCH] check return code for request_region() in gus_wave.c Hashem Masoud
2006-09-28 10:40 ` Hashem Masoud
2006-09-28 12:06 ` [KJ] [PATCH] check return code for request_region() Amol Lad
2006-09-28 23:44 ` [KJ] [PATCH] check return code for request_region() in gus_wave.c Hashem Masoud
2006-09-29 0:08 ` [KJ] [PATCH] check return code for request_region() in Jesper Juhl
2006-09-29 13:02 ` Hashem Masoud
2006-09-29 13:16 ` Jesper Juhl
2006-09-29 18:59 ` Hashem Masoud [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060929185939.GA8167@localhost.localdomain \
--to=masoudh@batelco.com.bh \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.