All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hashem Masoud <masoudh@batelco.com.bh>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] check return code for request_region() in
Date: Fri, 29 Sep 2006 13:02:36 +0000	[thread overview]
Message-ID: <451D196C.5010301@batelco.com.bh> (raw)
In-Reply-To: <20060928103514.GA12240@localhost.localdomain>

Jesper Juhl wrote:

>> +++ linux/sound/oss/gus_wave.c  2006-09-28 20:17:41.093694160 -0300
>> @@ -2938,7 +2938,10 @@ void __init gus_wave_init(struct address
>>                         model_num = "3.7";
>>                         gus_type = 0x37;
>>                         mixer_type = ICS2101;
>> -                       request_region(u_MixSelect, 1, "GUS mixer");
>> +                       if !(request_region(u_MixSelect, 1, "GUS 
>> mixer")) {
> 
> 
> ... and it shows ^^^^^

BTW, Google web mail access automatically translates tabs into spaces, but if you download your e-mails using POP access this won't happen.
Also, check the patch posted to list, it is intact: http://lists.osdl.org/pipermail/kernel-janitors/2006-September/007352.html

> 
> Please take the time to do minimal testing. Not doing so is a waste of
> a lot of peoples time.
> 
> 

Thanks. I Tested the 2 previous patches through make allmodconfig and make sound/oss/ .


-- 
Hashem Masoud
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2006-09-29 13:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-28 10:35 [KJ] [PATCH] check return code for request_region() in gus_wave.c Hashem Masoud
2006-09-28 10:40 ` Hashem Masoud
2006-09-28 12:06 ` [KJ] [PATCH] check return code for request_region() Amol Lad
2006-09-28 23:44 ` [KJ] [PATCH] check return code for request_region() in gus_wave.c Hashem Masoud
2006-09-29  0:08 ` [KJ] [PATCH] check return code for request_region() in Jesper Juhl
2006-09-29 13:02 ` Hashem Masoud [this message]
2006-09-29 13:16 ` Jesper Juhl
2006-09-29 18:59 ` Hashem Masoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=451D196C.5010301@batelco.com.bh \
    --to=masoudh@batelco.com.bh \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.