From: Arnd Bergmann <arnd@arndb.de>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: akpm@osdl.org, jeff@garzik.org, netdev@vger.kernel.org,
James K Lewis <jklewis@us.ibm.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 4/6]: powerpc/cell spidernet ethtool -i version number info.
Date: Sat, 30 Sep 2006 12:33:45 +0200 [thread overview]
Message-ID: <200609301233.45871.arnd@arndb.de> (raw)
In-Reply-To: <20060929232139.GL6433@austin.ibm.com>
Am Saturday 30 September 2006 01:21 schrieb Linas Vepstas:
> This patch adds version information as reported by
> ethtool -i to the Spidernet driver.
>
> From: James K Lewis <jklewis@us.ibm.com>
> Signed-off-by: James K Lewis <jklewis@us.ibm.com>
> Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
Same comment as last time this was submitted:
> @@ -2303,6 +2304,8 @@ static struct pci_driver spider_net_driv
> =A0 */
> =A0static int __init spider_net_init(void)
> =A0{
> +=A0=A0=A0=A0=A0=A0=A0printk("spidernet Version %s.\n",VERSION);
> +
> =A0=A0=A0=A0=A0=A0=A0=A0if (rx_descriptors < SPIDER_NET_RX_DESCRIPTORS_MI=
N) {
> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0rx_descriptors =3D SPIDER=
_NET_RX_DESCRIPTORS_MIN;
> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0pr_info("adjusting rx des=
criptors to %i.\n",
This is missing a printk level and a space character. More importantly,
you should not print the presence of the driver to the syslog, but
the presence of a device driven by it.
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: jeff@garzik.org, akpm@osdl.org, netdev@vger.kernel.org,
James K Lewis <jklewis@us.ibm.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 4/6]: powerpc/cell spidernet ethtool -i version number info.
Date: Sat, 30 Sep 2006 12:33:45 +0200 [thread overview]
Message-ID: <200609301233.45871.arnd@arndb.de> (raw)
In-Reply-To: <20060929232139.GL6433@austin.ibm.com>
Am Saturday 30 September 2006 01:21 schrieb Linas Vepstas:
> This patch adds version information as reported by
> ethtool -i to the Spidernet driver.
>
> From: James K Lewis <jklewis@us.ibm.com>
> Signed-off-by: James K Lewis <jklewis@us.ibm.com>
> Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
Same comment as last time this was submitted:
> @@ -2303,6 +2304,8 @@ static struct pci_driver spider_net_driv
> */
> static int __init spider_net_init(void)
> {
> + printk("spidernet Version %s.\n",VERSION);
> +
> if (rx_descriptors < SPIDER_NET_RX_DESCRIPTORS_MIN) {
> rx_descriptors = SPIDER_NET_RX_DESCRIPTORS_MIN;
> pr_info("adjusting rx descriptors to %i.\n",
This is missing a printk level and a space character. More importantly,
you should not print the presence of the driver to the syslog, but
the presence of a device driven by it.
Arnd <><
next prev parent reply other threads:[~2006-09-30 10:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-29 23:05 [PATCH 0/6]: powerpc/cell spidernet ethernet patches Linas Vepstas
2006-09-29 23:05 ` Linas Vepstas
2006-09-29 23:15 ` [PATCH 1/6]: powerpc/cell spidernet burst alignment patch Linas Vepstas
2006-09-30 10:29 ` Arnd Bergmann
2006-09-30 10:29 ` Arnd Bergmann
2006-09-29 23:17 ` [PATCH 2/6]: powerpc/cell spidernet low watermark patch Linas Vepstas
2006-09-30 10:30 ` Arnd Bergmann
2006-09-30 10:30 ` Arnd Bergmann
2006-09-29 23:19 ` [PATCH 3/6]: powerpc/cell spidernet stop error printing patch Linas Vepstas
2006-09-30 10:32 ` Arnd Bergmann
2006-09-30 10:32 ` Arnd Bergmann
2006-09-29 23:21 ` [PATCH 4/6]: powerpc/cell spidernet ethtool -i version number info Linas Vepstas
2006-09-30 10:33 ` Arnd Bergmann [this message]
2006-09-30 10:33 ` Arnd Bergmann
2006-10-02 17:14 ` Linas Vepstas
2006-10-02 17:14 ` Linas Vepstas
2006-09-29 23:26 ` [PATCH 5/6]: powerpc/cell spidernet ethtool -i version number Linas Vepstas
2006-09-30 10:35 ` Arnd Bergmann
2006-09-30 10:35 ` Arnd Bergmann
2006-09-29 23:29 ` [PATCH 6/6]: powerpc/cell spidernet refine locking Linas Vepstas
2006-09-30 2:47 ` Andrew Morton
2006-09-30 2:47 ` Andrew Morton
2006-10-02 17:47 ` Linas Vepstas
2006-10-02 17:47 ` Linas Vepstas
2006-09-30 10:40 ` [PATCH 0/6]: powerpc/cell spidernet ethernet patches Arnd Bergmann
2006-09-30 10:40 ` Arnd Bergmann
2006-10-02 16:27 ` Linas Vepstas
2006-10-02 16:27 ` Linas Vepstas
2006-10-02 16:50 ` Arnd Bergmann
2006-10-02 16:50 ` Arnd Bergmann
2006-10-02 17:23 ` Linas Vepstas
2006-10-02 17:23 ` Linas Vepstas
-- strict thread matches above, loose matches on Subject: below --
2006-08-18 22:07 [PATCH 0/6]: powerpc/cell spidernet ethernet driver update Linas Vepstas
2006-08-18 22:25 ` [PATCH 4/6]: powerpc/cell spidernet ethtool -i version number info Linas Vepstas
2006-08-18 22:56 ` Arnd Bergmann
2006-08-18 22:56 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609301233.45871.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=jklewis@us.ibm.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.